Oct 14 2021
Aug 2 2021
Jul 29 2021
Jul 28 2021
Jul 27 2021
Jul 23 2021
I'd like to see it in action - I don't have a great sense of how this actually gets used and adding a test to describe that behavior would be great.
Jul 22 2021
Do we have a hypothesis for why this would cause issues this week but not last?
@jordansanders how strongly do you feel about stars vs. dashes? I don't mind changing this time, but fairly annoying if that needs to be another step in the release guide. (the stars are generated by the Quip markdown export).
Let's definitely remove the "Added information" line 😄
Jul 21 2021
Do we support termination? Dagit makes that api call if so
Return false if can_terminate can't look up any tasks
Remove unnecessary dagit permissions (these were only included because https://dagster.phacility.com/D8978 hasn't landed yet)
Add StopTask permission to dagit and add a sleep to the solid so it's easier to manually test
Jul 20 2021
Jul 16 2021
users might still run into this issue when their image contains an ENTRYPOINT.
Jul 15 2021
Jul 8 2021
This is a really good change - we should more explicitly test it and be a little bit more defensive w/r/t passing strings around.
Jul 7 2021
Jul 6 2021
Fixup diff description
Take it with a grain of salt, but it looks like we backed away from pre-commit hooks once before as well:
I don't personally love git-hooks and find them to often be more of a hinderance than a help: https://www.thoughtworks.com/en-us/insights/blog/pre-commit-don-t-git-hooked
Jul 2 2021
Jul 1 2021
Use the new instance_cm fixture instead of the build_instance fixture (which no longer exists)
Refactor to return a contextmanager
Rearrange stack so this comes first
Jun 30 2021