see one comment, otherwise LGTM! thanks for setting this up
Moved this diff to do the exact opposite, in https://dagster.phacility.com/D4156
This looks great! My one lingering concern is about whether we need to maintain compatibility with the TypeStoragePlugin interface for now.
mock DagsterInstance.get() when calling CliRunner functions, so that run_launcher.join() will work
slightly grosser fix to deal with managed grpc servers in a similar way - need to find any handles that the grpc run launcher launched, shut down their server processes, and wait for them to finish (we don't create them in a test context so we can't clean them up there)
yeah I think we concluded at the end of last week that the existing behavior is actually giving us what we want?
Sun, Aug 9
Sat, Aug 8
Also wait for any grpc server processes to make sure they're all cleaned up before the instance tries to clean up.
I've followed this example flow locally and replaced the token string in the yaml with my own one. It feels pretty lightweight and easy to follow.
Fri, Aug 7
test that it fails without fixing diff
spurious sqlite issue ^^ rerunning-turns-green
disable telemetry by default in CLI tests, use a helper method for mocked instances that will persist if you call them in subprocesses
tests are still failing on windows due to the telemetry log
update k8s-example image
more cli tests
add issue #