Feed All Stories
Today
Today
Re-enable test_reconstructable.py tests
aj.nadel requested review of D4154: WIP implement composite solids.
Yesterday
Yesterday
see one comment, otherwise LGTM! thanks for setting this up
Harbormaster failed remote builds in B16747: Diff 20422 for D4129: implement configured intermediate_storage, system_storage!
johann requested review of D4155: kind cluster info dump in buildkite.
aj.nadel updated the diff for D4129: implement configured intermediate_storage, system_storage.
black
Harbormaster failed remote builds in B16745: Diff 20419 for D4129: implement configured intermediate_storage, system_storage!
aj.nadel updated the diff for D4129: implement configured intermediate_storage, system_storage.
up
yuhan planned changes to D4107: step-selection-1 parse step selection.
Moved this diff to do the exact opposite, in https://dagster.phacility.com/D4156
aj.nadel requested review of D4129: implement configured intermediate_storage, system_storage.
sandyryza added inline comments to D4087: nicer error on failure to load repository in external process.
sandyryza accepted D4098: (Depends on D4070) Incorporated IntermediateStore features into IntermediateStorage, fixed tests and subclasses accordingly..
This looks great! My one lingering concern is about whether we need to maintain compatibility with the TypeStoragePlugin interface for now.
dgibson updated the diff for D4145: Refactor CLI tests to pass in contexts for managed and unmanaged GRPC servers.
mock DagsterInstance.get() when calling CliRunner functions, so that run_launcher.join() will work
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
slightly grosser fix to deal with managed grpc servers in a similar way - need to find any handles that the grpc run launcher launched, shut down their server processes, and wait for them to finish (we don't create them in a test context so we can't clean them up there)
johann requested review of D4152: Pass tags to PipelineSubsetDef.
dgibson requested changes to D4122: Even softer termination scheme.
yeah I think we concluded at the end of last week that the existing behavior is actually giving us what we want?
dgibson added inline comments to D4087: nicer error on failure to load repository in external process.
Harbormaster failed remote builds in B16730: Diff 20403 for D4145: Refactor CLI tests to pass in contexts for managed and unmanaged GRPC servers!
dgibson updated the diff for D4145: Refactor CLI tests to pass in contexts for managed and unmanaged GRPC servers.
up
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
up
Sun, Aug 9
Sun, Aug 9
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
up
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
py2
Sat, Aug 8
Sat, Aug 8
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
Also wait for any grpc server processes to make sure they're all cleaned up before the instance tries to clean up.
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
test fixes
Harbormaster failed remote builds in B16721: Diff 20394 for D4140: test subset execution in celery-k8s!
yuhan added a comment to D4119: [docs] examples/hooks.
I've followed this example flow locally and replaced the token string in the yaml with my own one. It feels pretty lightweight and easy to follow.
Harbormaster failed remote builds in B16717: Diff 20390 for D4140: test subset execution in celery-k8s!
Fri, Aug 7
Fri, Aug 7
dgibson updated the summary of D4145: Refactor CLI tests to pass in contexts for managed and unmanaged GRPC servers.
Harbormaster failed remote builds in B16715: Diff 20388 for D4140: test subset execution in celery-k8s!
yuhan requested review of D4147: ResourceDefinition.mock_resource.
johann updated the summary of D4140: test subset execution in celery-k8s.
johann updated the diff for D4140: test subset execution in celery-k8s.
reset change
johann updated the diff for D4140: test subset execution in celery-k8s.
test that it fails without fixing diff
johann requested review of D4146: changelog.
johann updated the diff for D4140: test subset execution in celery-k8s.
modify config
Harbormaster failed remote builds in B16709: Diff 20381 for D4140: test subset execution in celery-k8s!
johann updated the summary of D4140: test subset execution in celery-k8s.
One more flaky test failure on windows
dgibson requested review of D4144: One more flaky test failure on windows.
Harbormaster failed remote builds in B16705: Diff 20374 for D4140: test subset execution in celery-k8s!
prha requested review of D4143: Re-enable test_reconstructable.py tests.
johann committed R1:e5a1e449ac5f: support subsets in execute_step_with_structured_logs (authored by johann).
support subsets in execute_step_with_structured_logs
johann added reviewers for D4139: support subsets in execute_step_with_structured_logs: prha, max, nate.
johann updated the test plan for D4139: support subsets in execute_step_with_structured_logs.
make ipc errors easier to read
prha added a comment to D4133: make ipc errors easier to read.
spurious sqlite issue ^^ rerunning-turns-green
prha requested review of D4133: make ipc errors easier to read.
johann requested review of D4139: support subsets in execute_step_with_structured_logs.
cdecarolis requested review of D4021: lakehouse example.
johann requested review of D4140: test subset execution in celery-k8s.
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
disable telemetry by default in CLI tests, use a helper method for mocked instances that will persist if you call them in subprocesses
Disable tests currently breaking Windows
dgibson planned changes to D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
tests are still failing on windows due to the telemetry log
Harbormaster failed remote builds in B16691: Diff 20355 for D4137: Add cleanup thread to grpc server!
dgibson requested review of D4137: Add cleanup thread to grpc server.
Harbormaster failed remote builds in B16692: Diff 20356 for D4135: Disable tests currently breaking Windows!
Rename runmaster to run_coordinator
dgibson updated the diff for D4136: Re-enable CLI execute/launch/backfill commands on windows (by eliminating sources of tempdir contention).
up
dgibson updated the diff for D4135: Disable tests currently breaking Windows.
one more
johann updated the diff for D4134: add editable image to dagster-image.
update k8s-example image
dgibson updated the diff for D4135: Disable tests currently breaking Windows.
more cli tests
dgibson updated the diff for D4135: Disable tests currently breaking Windows.
add issue #
dgibson requested review of D4135: Disable tests currently breaking Windows.