oops, accidentally removed a flag
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
I'm not sure how easy it'd be to retrieve repoAddress within the component...
Yesterday
One thing that I'm concerned about is communicating the failure modes of the resolution mechanism that we're doing here. It's a bit of magic, and there's a lot of ways each can fail.
Up
Removed comment, removed recorder
add test and docs
Nice. Would love this in the run list viewer too!
This seems like a nice presentation - I think we've been struggling for a while to find a consistent home for "mode" that doesn't make it look like a tag. I like having the <PipelineAndMode> component to wrap up the UI - I wonder if we could push the href generation down into that component in any way? I'm not sure how easy it'd be to retrieve repoAddress within the component...
Oh this is super cool - nice that we don't need moment for this sort of thing these days.
blk
add deprecation warning
@alangenfeld any objections
rebase and backcompat
In D6783#179953, @alangenfeld wrote:TEST PLAN
bkmight be good to try to run the specific test a whole bunch of times to verify
Using a tag here seems OK to me. Adding tags can also be race-condition-y though... e.g. if this tag gets added while the run launcher is in the middle of adding other tags, bad things can happen (mostly since there are two sources of truth for the run tags - the serialized tags in the runs table, and the columns in the run tags table).