Page MenuHomePhabricator
Feed All Stories

Today

rexledesma updated the diff for D6806: Fix helm-release cli.

oops, accidentally removed a flag

Fri, Mar 5, 7:09 AM
rexledesma published D6806: Fix helm-release cli for review.
Fri, Mar 5, 7:08 AM
yuhan closed D6805: fix indentation in versions.yaml.
Fri, Mar 5, 6:10 AM
yuhan committed R1:4a9d266f87fc: fix indentation in versions.yaml (authored by yuhan).
fix indentation in versions.yaml
Fri, Mar 5, 6:10 AM
rexledesma accepted D6805: fix indentation in versions.yaml.

Macro didntread:

Fri, Mar 5, 6:06 AM
yuhan requested review of D6805: fix indentation in versions.yaml.
Fri, Mar 5, 6:04 AM
max closed D6768: Allow config for custom instance classes.
Fri, Mar 5, 3:59 AM
max committed R1:0bcadea1f357: Allow config for custom instance classes (authored by max).
Allow config for custom instance classes
Fri, Mar 5, 3:59 AM
max closed D6764: Factor instance weakref machinery into a mixin.
Fri, Mar 5, 3:59 AM
max committed R1:de75f1d0fff5: Factor instance weakref machinery into a mixin (authored by max).
Factor instance weakref machinery into a mixin
Fri, Mar 5, 3:59 AM
sidkmenon added reviewers for D6784: [core] Adding destructor to SqlPollingEventWatcher: catherinewu, rexledesma, bob.
Fri, Mar 5, 2:10 AM
prha accepted D6796: Re-enable flaky daemon test.

whynot

Fri, Mar 5, 1:57 AM
dish closed D6724: [dagit] Localize elapsed time and logs timestamps.
Fri, Mar 5, 1:28 AM
dish committed R1:245ee124968c: [dagit] Localize elapsed time and logs timestamps (authored by dish).
[dagit] Localize elapsed time and logs timestamps
Fri, Mar 5, 1:28 AM
prha closed D6803: fix unscheduled count for legacy backfills.
Fri, Mar 5, 1:28 AM
prha committed R1:c49d7fc6223b: fix unscheduled count for legacy backfills (authored by prha).
fix unscheduled count for legacy backfills
Fri, Mar 5, 1:28 AM
dish closed D6744: [dagit] Move mode alongside pipeline name.
Fri, Mar 5, 1:25 AM
dish committed R1:3d623b8d971e: [dagit] Move mode alongside pipeline name (authored by dish).
[dagit] Move mode alongside pipeline name
Fri, Mar 5, 1:25 AM
dish added a comment to D6744: [dagit] Move mode alongside pipeline name.

I'm not sure how easy it'd be to retrieve repoAddress within the component...

Fri, Mar 5, 1:21 AM
dish closed D6791: [dagit] Allow Group wrapping.
Fri, Mar 5, 1:19 AM
dish committed R1:95dfdddbda81: [dagit] Allow Group wrapping (authored by dish).
[dagit] Allow Group wrapping
Fri, Mar 5, 1:19 AM
dish closed D6792: [dagit] Separate pipeline and snapshot links in Run header.
Fri, Mar 5, 1:18 AM
dish committed R1:def50f8da17c: [dagit] Separate pipeline and snapshot links in Run header (authored by dish).
[dagit] Separate pipeline and snapshot links in Run header
Fri, Mar 5, 1:18 AM
dish accepted D6803: fix unscheduled count for legacy backfills.
Fri, Mar 5, 1:12 AM
yuhan committed R1:9cd71c3d717e: [Docs] 0.10.8 (authored by yuhan).
[Docs] 0.10.8
Fri, Mar 5, 1:10 AM
prha requested review of D6803: fix unscheduled count for legacy backfills.
Fri, Mar 5, 1:10 AM
prha closed D6794: remove tqdm unless printing.
Fri, Mar 5, 12:47 AM
prha committed R1:ad551f0e9707: remove tqdm unless printing (authored by prha).
remove tqdm unless printing
Fri, Mar 5, 12:47 AM
Chris DeCarolis <cdguitar817@gmail.com> closed D6787: [4/n init_resources] init_resources context manager.
Fri, Mar 5, 12:22 AM
Chris DeCarolis <cdguitar817@gmail.com> committed R1:aacc40de5ba4: [4/n init_resources] init_resources context manager (authored by Chris DeCarolis <cdguitar817@gmail.com>).
[4/n init_resources] init_resources context manager
Fri, Mar 5, 12:22 AM
yuhan committed R1:ac447bf00c7c: 0.10.8 (authored by yuhan).
0.10.8
Fri, Mar 5, 12:12 AM

Yesterday

dgibson requested review of D6801: Add a DaemonRepositoryLocationOrigin.
Thu, Mar 4, 11:57 PM
alangenfeld added inline comments to D6797: Launch API.
Thu, Mar 4, 11:56 PM
yuhan committed R1:0a518897f655: 0.10.8.pre0 (authored by yuhan).
0.10.8.pre0
Thu, Mar 4, 11:50 PM
prha accepted D6795: Include stack trace when there's a failure submitting runs from the scheduler or sensors.
Thu, Mar 4, 11:49 PM
yuhan closed D6802: CHANGES for 0.10.8.
Thu, Mar 4, 11:39 PM
yuhan committed R1:e9628448d4e9: CHANGES for 0.10.8 (authored by yuhan).
CHANGES for 0.10.8
Thu, Mar 4, 11:39 PM
sashank closed D6736: [docs] Instance and Daemon pages.
Thu, Mar 4, 11:27 PM
sashank committed R1:0d861bab1a47: [docs] Instance and Daemon pages (authored by sashank).
[docs] Instance and Daemon pages
Thu, Mar 4, 11:27 PM
cdecarolis added inline comments to D6797: Launch API.
Thu, Mar 4, 11:04 PM
alangenfeld requested review of D6782: Retries -> RetryMode & RetryState.
Thu, Mar 4, 11:03 PM
alangenfeld added inline comments to D6797: Launch API.
Thu, Mar 4, 10:36 PM
bob requested review of D6799: Turns relative imports into absolute imports, and removes imports in __init__ (for generated project skeleton)..
Thu, Mar 4, 10:24 PM
Harbormaster failed remote builds in B26881: Diff 32857 for D6787: [4/n init_resources] init_resources context manager!
Thu, Mar 4, 10:08 PM
cdecarolis added a comment to D6797: Launch API.

One thing that I'm concerned about is communicating the failure modes of the resolution mechanism that we're doing here. It's a bit of magic, and there's a lot of ways each can fail.

Thu, Mar 4, 10:04 PM
dgibson requested review of D6796: Re-enable flaky daemon test.
Thu, Mar 4, 10:04 PM
cdecarolis requested review of D6797: Launch API.
Thu, Mar 4, 10:02 PM
dgibson requested review of D6795: Include stack trace when there's a failure submitting runs from the scheduler or sensors.
Thu, Mar 4, 10:00 PM
cdecarolis updated the diff for D6787: [4/n init_resources] init_resources context manager.

Up

Thu, Mar 4, 9:55 PM
cdecarolis updated the diff for D6787: [4/n init_resources] init_resources context manager.

Removed comment, removed recorder

Thu, Mar 4, 9:50 PM
dgibson abandoned D6762: Testbed for flaky test.
Thu, Mar 4, 9:44 PM
dgibson accepted D6768: Allow config for custom instance classes.
Thu, Mar 4, 9:44 PM
sidkmenon requested review of D6784: [core] Adding destructor to SqlPollingEventWatcher.
Thu, Mar 4, 9:40 PM
dgibson closed D6790: Clean up observer in sqlite event log.
Thu, Mar 4, 9:21 PM
dgibson committed R1:3ecdf0f744eb: Clean up observer in sqlite event log (authored by dgibson).
Clean up observer in sqlite event log
Thu, Mar 4, 9:21 PM
alangenfeld accepted D6794: remove tqdm unless printing.

diamond_diffs

Thu, Mar 4, 9:20 PM
prha requested review of D6794: remove tqdm unless printing.
Thu, Mar 4, 9:15 PM
alangenfeld accepted D6790: Clean up observer in sqlite event log.

redfordnod

Thu, Mar 4, 9:06 PM
max updated the diff for D6768: Allow config for custom instance classes.

blk

Thu, Mar 4, 9:05 PM
dgibson requested review of D6790: Clean up observer in sqlite event log.
Thu, Mar 4, 9:04 PM
Harbormaster failed remote builds in B26866: Diff 32839 for D6768: Allow config for custom instance classes!
Thu, Mar 4, 8:58 PM
prha closed D6789: add chunking for synchronous backfill.
Thu, Mar 4, 8:56 PM
prha committed R1:c54074c6dad8: add chunking for synchronous backfill (authored by prha).
add chunking for synchronous backfill
Thu, Mar 4, 8:56 PM
max closed D6793: Use ECR alias.
Thu, Mar 4, 8:55 PM
max committed R1:f0b84893772f: Use ECR alias (authored by max).
Use ECR alias
Thu, Mar 4, 8:55 PM
max updated the diff for D6768: Allow config for custom instance classes.

add test and docs

Thu, Mar 4, 8:39 PM
schrockn added a comment to D6792: [dagit] Separate pipeline and snapshot links in Run header.

Nice. Would love this in the run list viewer too!

Thu, Mar 4, 8:20 PM
bengotow accepted D6792: [dagit] Separate pipeline and snapshot links in Run header.
Thu, Mar 4, 8:19 PM
bengotow accepted D6791: [dagit] Allow Group wrapping.
Thu, Mar 4, 8:18 PM
bengotow accepted D6744: [dagit] Move mode alongside pipeline name.

This seems like a nice presentation - I think we've been struggling for a while to find a consistent home for "mode" that doesn't make it look like a tag. I like having the <PipelineAndMode> component to wrap up the UI - I wonder if we could push the href generation down into that component in any way? I'm not sure how easy it'd be to retrieve repoAddress within the component...

Thu, Mar 4, 8:17 PM
bengotow accepted D6724: [dagit] Localize elapsed time and logs timestamps.

Oh this is super cool - nice that we don't need moment for this sort of thing these days.

Thu, Mar 4, 8:14 PM
rexledesma accepted D6793: Use ECR alias.

diamond_diffs

Thu, Mar 4, 7:41 PM
max requested review of D6793: Use ECR alias.
Thu, Mar 4, 7:40 PM
max updated the diff for D6768: Allow config for custom instance classes.

rebase

Thu, Mar 4, 7:31 PM
dgibson accepted D6789: add chunking for synchronous backfill.
Thu, Mar 4, 7:17 PM
Harbormaster failed remote builds in B26858: Diff 32829 for D6764: Factor instance weakref machinery into a mixin!
Thu, Mar 4, 7:08 PM
max updated the diff for D6764: Factor instance weakref machinery into a mixin.

blk

Thu, Mar 4, 6:58 PM
dish requested review of D6792: [dagit] Separate pipeline and snapshot links in Run header.
Thu, Mar 4, 6:41 PM
dish requested review of D6791: [dagit] Allow Group wrapping.
Thu, Mar 4, 6:14 PM
prha requested review of D6777: added graphql-endpoints to wipe a single asset.
Thu, Mar 4, 6:12 PM
dgibson closed D6771: [easy] Be less restrictive about origins coming into GrpcServerRepositoryLocaitonHandle.
Thu, Mar 4, 6:03 PM
dgibson committed R1:38aa850efa19: [easy] Be less restrictive about origins coming into… (authored by dgibson).
[easy] Be less restrictive about origins coming into…
Thu, Mar 4, 6:03 PM
prha requested review of D6778: add wipe action to the new asset catalog (feature flagged).
Thu, Mar 4, 6:02 PM
dgibson closed D6743: Add 'use_ssl' boolean to grpc server workspace entry.
Thu, Mar 4, 6:01 PM
dgibson committed R1:9631fd5333a1: Add 'use_ssl' boolean to grpc server workspace entry (authored by dgibson).
Add 'use_ssl' boolean to grpc server workspace entry
Thu, Mar 4, 6:01 PM
max updated the diff for D6764: Factor instance weakref machinery into a mixin.

add deprecation warning

Thu, Mar 4, 6:00 PM
prha requested review of D6789: add chunking for synchronous backfill.
Thu, Mar 4, 5:50 PM
alangenfeld resigned from D6768: Allow config for custom instance classes.

@alangenfeld any objections

Thu, Mar 4, 5:46 PM
max updated the diff for D6764: Factor instance weakref machinery into a mixin.

rebase and backcompat

Thu, Mar 4, 5:33 PM
johann added inline comments to D6765: RFC: cancel runs via daemon.
Thu, Mar 4, 5:28 PM
Harbormaster failed remote builds in B26849: Diff 32816 for D6771: [easy] Be less restrictive about origins coming into GrpcServerRepositoryLocaitonHandle!
Thu, Mar 4, 5:25 PM
Sidharth Menon <menon.sid.k@gmail.com> closed D6783: [core][dagster-graphql] Fixing flaky dagster-graphql Polling Event Watcher tests.
Thu, Mar 4, 5:23 PM
Sidharth Menon <menon.sid.k@gmail.com> committed R1:768f2fe9c01c: [core][dagster-graphql] Fixing flaky dagster-graphql Polling Event Watcher tests (authored by Sidharth Menon <menon.sid.k@gmail.com>).
[core][dagster-graphql] Fixing flaky dagster-graphql Polling Event Watcher tests
Thu, Mar 4, 5:23 PM
dish closed D6788: [dagit] Bold object names in Schedules/Sensors tables.
Thu, Mar 4, 5:20 PM
dish committed R1:55803ecc23c1: [dagit] Bold object names in Schedules/Sensors tables (authored by dish).
[dagit] Bold object names in Schedules/Sensors tables
Thu, Mar 4, 5:20 PM
sidkmenon added a comment to D6783: [core][dagster-graphql] Fixing flaky dagster-graphql Polling Event Watcher tests.

TEST PLAN
bk

might be good to try to run the specific test a whole bunch of times to verify

Thu, Mar 4, 5:20 PM
prha closed D6776: flatten asset catalog table.
Thu, Mar 4, 5:18 PM
prha committed R1:5956ea714276: flatten asset catalog table (authored by prha).
flatten asset catalog table
Thu, Mar 4, 5:18 PM
dgibson accepted D6788: [dagit] Bold object names in Schedules/Sensors tables.
Thu, Mar 4, 5:17 PM
dgibson added a comment to D6765: RFC: cancel runs via daemon.

Using a tag here seems OK to me. Adding tags can also be race-condition-y though... e.g. if this tag gets added while the run launcher is in the middle of adding other tags, bad things can happen (mostly since there are two sources of truth for the run tags - the serialized tags in the runs table, and the columns in the run tags table).

Thu, Mar 4, 5:14 PM