Changeset View
Standalone View
.github/PULL_REQUEST_TEMPLATE.md
- This file was added.
| <!--- Hello Dagster contributor! It's great to have you with us! --> | |||||||||||
| <!-- Make sure to read https://docs.dagster.io/community/contributing --> | |||||||||||
| ## Summary | |||||||||||
| <!-- Describe your changes here, include the motivation/context, test coverage, --> | |||||||||||
| <!-- the type of change i.e. breaking change, new feature, or bug fix --> | |||||||||||
| <!-- and related issue or screenshots (if applicable). --> | |||||||||||
catherinewuUnsubmitted Done Inline Actions
catherinewu: | |||||||||||
Done Inline Actions
catherinewu: | |||||||||||
Done Inline ActionsI don't feel like this should be a requirement since it adds yet another thing that contributors have to do (death by a thousand cuts) catherinewu: I don't feel like this should be a requirement since it adds yet another thing that… | |||||||||||
Done Inline ActionsThese four items are writing prompts, not mandate requirement. yichendai: These four items are writing prompts, not mandate requirement. | |||||||||||
Done Inline ActionsMy comment referred to an earlier version that said catherinewu: My comment referred to an earlier version that said
"<!--- This project only accepts pull… | |||||||||||
Done Inline ActionsOoops, I prob skipped this comment and replied until I submitted an updated version 😓 yichendai: Ooops, I prob skipped this comment and replied until I submitted an updated version 😓 | |||||||||||
| ## Test Plan | |||||||||||
| <!--- Please describe the tests you have added and your testing environment (if applicable) --> | |||||||||||
catherinewuUnsubmitted Done Inline Actions
catherinewu: | |||||||||||
Done Inline Actions
catherinewu: | |||||||||||
Done Inline Actions
would remove this line catherinewu: would remove this line | |||||||||||
Done Inline ActionsI think we could be more clear that we would like to see test coverage in the diff itself (as opposed to tests run in local env manually) catherinewu: I think we could be more clear that we would like to see test coverage in the diff itself (as… | |||||||||||
| ## Checklist: | |||||||||||
Done Inline ActionsCan we fold this into the "Describe your changes" section? catherinewu: Can we fold this into the "Describe your changes" section? | |||||||||||
Done Inline ActionsI agree that we fold these to one session like @alangenfeld suggested below. yichendai: I agree that we fold these to one session like @alangenfeld suggested below. | |||||||||||
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | |||||||||||
| <!--- If you're unsure about any of these, don't hesitate to ask in our Slack--> | |||||||||||
| <!--- channel # contributors https://app.slack.com/client/TCDGQDUKF/C01K91YP0TF. We're here to help!--> | |||||||||||
catherinewuUnsubmitted Done Inline Actions
catherinewu: | |||||||||||
yichendaiAuthorUnsubmitted Done Inline ActionsThe link in comment <!--- ---> is not clickable. I attached an example from Gatsby's issue template in Quip docs if you want to see how it looks like. yichendai: The link in comment <!--- ---> is not clickable. I attached an example from Gatsby's issue… | |||||||||||
catherinewuUnsubmitted Done Inline ActionsThats true catherinewu: Thats true | |||||||||||
Done Inline Actionscan we link directly to the contributors channel as we discussed? catherinewu: can we link directly to the contributors channel as we discussed? | |||||||||||
Done Inline Actionsfor some reason I didn't save that change. Update soon! yichendai: for some reason I didn't save that change. Update soon! | |||||||||||
Done Inline Actions
catherinewu: | |||||||||||
| - [ ] My change requires a change to the documentation and I have updated the documentation accordingly. | |||||||||||
| - [ ] I have added tests to cover my changes. | |||||||||||
Done Inline Actions
catherinewu: | |||||||||||
| No newline at end of file | |||||||||||
Done Inline ActionsJust to give a sense of what I meant, this is an approximation of what I think would be a good place to start: <!-- Hello Dagster contributor! It's great to have you with us! --> <!-- Make sure to read https://docs.dagster.io/community/contributing --> ## Summary <!-- Describe your changes here, include things like: --> <!-- related issue --> <!-- type of change i.e. breaking change, new feature, or bug fix --> <!-- motivation and context --> <!-- screenshots --> ## Test Plan <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> This is very much a matter of personal taste so its hard to say this is better or worse. alangenfeld: Just to give a sense of what I meant, this is an approximation of what I think would be a good… | |||||||||||
Done Inline ActionsI think we should publish something about code style before asking users to check this. lint + code review should be sufficient till then imo catherinewu: I think we should publish something about code style before asking users to check this. lint +… | |||||||||||
Done Inline ActionsThe code style in contributing guide will pop up automatically when a contributor opens a PR once this diff is out. yichendai: The code style in [[ https://docs.dagster.io/community/contributing | contributing guide ]]… | |||||||||||
Done Inline ActionsCan we add a link to Slack here? catherinewu: Can we add a link to Slack here? | |||||||||||
Done Inline Actions
catherinewu: | |||||||||||