HomeElementl

Add an error boundary around check_add_heartbeat in daemon loop

Description

Add an error boundary around check_add_heartbeat in daemon loop

Summary: There are two heartbeat additions here in this file - we wrapped one of them in a guard but not the other one. This diff adds it to the other one.

Test Plan: BK, run a daemon that fails this check (e.g. with bad run storage credentials), daemon logs instead of crashing. Heartbeat failures may eventually cause it to crash, but not right away.

Reviewers: johann, rexledesma, alangenfeld

Reviewed By: rexledesma

Differential Revision: https://dagster.phacility.com/D9020

Details

Provenance
dgibsonAuthored on Jul 22 2021, 6:39 PM
Reviewer
rexledesma
Differential Revision
D9020: Add an error boundary around check_add_heartbeat in daemon loop
Parents
R1:e95742d174df: support get_mapping_key in direct invocation
Branches
Unknown
Tags
Unknown