HomePhabricator

RFC DagsterType.name -> DagsterType.unique_name

Description

RFC DagsterType.name -> DagsterType.unique_name

Summary:
There are a bunch of bad error messages since name on DagsterType is this sort of confusing property related to uniqueness, and display_name is the thing you want.

To address this, self.name -> self._name and add a getter for unique_name, and update all the callsites to use either display or unique name accordingly.

This diff doesn't change the input arg to DagsterType, since i think that isn't as problematic and is more costly to change.

Test Plan: bk

Reviewers: schrockn, dgibson, max, rexledesma

Reviewed By: dgibson

Differential Revision: https://dagster.phacility.com/D5111

Details

Provenance
alangenfeldAuthored on Wed, Nov 11, 11:04 PM
Reviewer
dgibson
Differential Revision
D5111: RFC DagsterType.name -> DagsterType.unique_name
Parents
R1:cd1fc735b376: Mark complex cycle grpc test as skipped due to flakiness
Branches
Unknown
Tags
Unknown