HomePhabricator

Fix test_sync_list_container_grpc running locally outside of BK
f1322340e328Unpublished

Unpublished Commit ยท Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Fix test_sync_list_container_grpc running locally outside of BK

Summary:

  • Cache the docker image locally so the test doesn't take a bunch of time every time it runs locally (with a message with a command to run to invalidate it, like the other docker tests)
  • Fix an errant contextmanager that was causing the docker container to never spin up when the test runs outside of BK

Test Plan: Run api_tests locally, no longer gets stuck on this test

Reviewers: sashank, alangenfeld

Differential Revision: https://dagster.phacility.com/D4973

Details

Provenance
dgibsonAuthored on Oct 29 2020, 9:05 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.