HomeElementl

retry from failure fan-in bug

Description

retry from failure fan-in bug

Summary:
https://github.com/dagster-io/dagster/issues/4325

the bug was that FromMultipleSources didn't check logs of transitive parent runs. this diff moves the similar logics into one place, i.e. StepExecutionContext._get_source_run_id_from_logs

I think the ideal fix is to record that kind of info (e.g. source run id) in places like KnownExecutionState, but this isn't a user-facing improvement, so will explore that after the release. tracking: https://github.com/dagster-io/dagster/issues/3511

Test Plan: added test

Reviewers: alangenfeld

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D8619

Details

Provenance
alangenfeldAuthored on Jul 7 2021, 3:11 AM
yuhanCommitted on Jul 7 2021, 8:00 PM
Reviewer
alangenfeld
Differential Revision
D8619: retry from failure fan-in bug
Parents
R1:acf7b7c24690: [docs] composite multiple outputs
Branches
Unknown
Tags
Unknown