Use compat layer for typing introspection
e2b7333ac668
Actions

Description

Use compat layer for typing introspection

Summary: Use a backport of the python 3.8 typing.get_args and typing.get_origin APIs to clarify our type introspection. Adds tests to clarify current behavior.

Test Plan: Unit

Reviewers: schrockn, alangenfeld, dgibson, prha, sandyryza

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D8086

Details

Provenance

max	Authored on May 25 2021, 5:25 PM

Reviewer

alangenfeld

Differential Revision

D8086: Use compat layer for typing introspection

Parents

R1:4a00ecd2cc2f: get_execution_data -> evaluate_tick

Branches

Unknown

Tags

Unknown

Event Timeline

max committed R1:e2b7333ac668: Use compat layer for typing introspection (authored by max).May 26 2021, 4:54 PM

max added an edge: D8086: Use compat layer for typing introspection.

Changes (4)

Path

Size

python_modules/

dagster/

seven/

typing.py

utils/

typing_api.py

dagster_tests/

general_tests/

utils_tests/

test_typing_api.py

setup.py

R1:e2b7333ac668

View Options

python_modules/dagster/dagster/seven/typing.py

View Options

python_modules/dagster/dagster/utils/typing_api.py

View Options

python_modules/dagster/dagster_tests/general_tests/utils_tests/test_typing_api.py

View Options

python_modules/dagster/setup.py

Use compat layer for typing introspectione2b7333ac668Actions

Description

Details

Event Timeline

Changes (4)

R1:e2b7333ac668

python_modules/dagster/dagster/seven/typing.py

python_modules/dagster/dagster/utils/typing_api.py

python_modules/dagster/dagster_tests/general_tests/utils_tests/test_typing_api.py

python_modules/dagster/setup.py

Use compat layer for typing introspection
e2b7333ac668
Actions