HomeElementl

Clean up in ComputeLogManager on instance cleanup

Description

Clean up in ComputeLogManager on instance cleanup

Summary:
Best I can tell from https://buildkite.com/dagster/dagster/builds/14878#ddfa5e35-46ae-40f9-99d0-222a1dfb203b

is that there's an issue during teardown:
"Unhandled exception in thread started by <bound method PollingObserver.__bootstrap of <PollingObserver(Thread-82, stopped daemon 139963773277952)>>"

This is an attempt to address that by adding a stop() call to the cleanup path.

Test Plan: BK and pray

Reviewers: alangenfeld

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D4856

Details

Provenance
dgibsonAuthored on Oct 21 2020, 6:29 PM
Reviewer
alangenfeld
Differential Revision
D4856: Clean up in ComputeLogManager on instance cleanup
Parents
R1:bc0d00572e08: Yet another line number fix 😔
Branches
Unknown
Tags
Unknown