HomePhabricator

More clear name properties for config types and graphql scalar union support

Description

More clear name properties for config types and graphql scalar union support

Summary:
This PR buckets up three changes:

  1. In the GraphQL schema for config types we rename name to givenName,

make it non-nullable, and move it to the only two subtypes that have
given names, enums and "regular" types.

  1. Flow Scalar Union down to GraphQL and render them in the config

editor. Typeahead still does not work

  1. Makes the input hydration config just a dictionary with "value",

"json", and "pickle" keys rather than a scalar union, which in the
case of Any was an ambiguous parse.

Test Plan: BK. Use config editor. See attached screenshot.

Reviewers: prha, alangenfeld

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D1828

Details

Provenance
schrocknAuthored on Jan 13 2020, 4:50 PM
Reviewer
alangenfeld
Differential Revision
D1828: More clear name properties for config types and graphql scalar union support
Parents
R1:caf395b99ff9: Check for duplicative runtime type names
Branches
Unknown
Tags
Unknown