HomePhabricator

Rename get_or_create_run() => register_managed_run() and other clean up

Authored by catherinewu on Tue, May 19, 10:02 PM.

Description

Rename get_or_create_run() => register_managed_run() and other clean up

Summary:
Follow up to address comments in https://dagster.phacility.com/D2719
From @schrockn "I also think we should do some things to the naming to make this clearer (feel free to do this in follow on)

Make it clear that this is the codepath for creating "MANAGED" runs. register_managed_run maybe?
Eliminate the status argument.
While we're at it, eliminate all default values for the arguments. It is super easy to forget one and they cause more harm than their potential convenience."

Test Plan: No change in functionality (except one change in flyte compiler)

Reviewers: schrockn, jordanbramble

Reviewed By: schrockn

Subscribers: schrockn

Differential Revision: https://dagster.phacility.com/D2996

Details

Committed
catherinewuThu, May 21, 7:53 PM
Reviewer
schrockn
Differential Revision
D2996: Rename get_or_create_run() => register_managed_run() and other clean up
Parents
R1:69c5702154c3: Add Airflow issue comment
Branches
Unknown
Tags
Unknown