HomePhabricator

fix resume/retry for optional output steps

Authored by prha on Mar 16 2020, 10:25 PM.

Description

fix resume/retry for optional output steps

Summary:
We weren't testing this code path, which only gets applied in the graphql layer... Added a test
that flexes the relevant case, where we had steps that had no output at all. This would not get caught by
the simplistic check that looked for any steps that did not yield the expected output.

This diff makes it so that all downstream dependencies of failures will be re-run. It does change the
resume/retry behavior for steps that did not yield all of its optional outputs, but succeeded, by not
including them in the resume/retry run.

Test Plan: added graphql test

Reviewers: alangenfeld, sashank

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D2265

Details

Committed
prhaMar 16 2020, 11:11 PM
Reviewer
alangenfeld
Differential Revision
D2265: fix resume/retry for optional output steps
Parents
R1:081585fb6798: (dagster-type-namespace-graphql-3) Add SolidDefMeta and dependents
Branches
Unknown
Tags
Unknown