HomePhabricator

short circuit canTerm logic

Description

short circuit canTerm logic

Summary:
Observed in speedscope

, canTerminate is suprisingly expensive since we re-fetch the run everytime since we only pass the id, despite having the full pipeline run.

We should consider changing the api, but that is a breaking change so for now just short circuit the "common" case

Test Plan: bk

Reviewers: dgibson, prha

Reviewed By: prha

Differential Revision: https://dagster.phacility.com/D4842

Details

Provenance
alangenfeldAuthored on Oct 20 2020, 10:11 PM
Reviewer
prha
Differential Revision
D4842: short circuit canTerm logic
Parents
R1:ca0db573fe08: memoize get_alembic_config
Branches
Unknown
Tags
Unknown