HomePhabricator

ensure `on_complete` called for completed compute log subscriptions

Authored by prha on Wed, Oct 9, 6:59 PM.

Description

ensure on_complete called for completed compute log subscriptions

Summary:
Previously, we were calling on_complete for observers only if the step compute completed
after the observer had subcribed. This change checks for compute completion upon subscription and
calls on_complete accordingly

Test Plan: Opened logs for historical runs, saw complete calls fire.

Reviewers: #ft, alangenfeld

Reviewed By: #ft, alangenfeld

Differential Revision: https://dagster.phacility.com/D1255

Details

Committed
prhaWed, Oct 9, 9:17 PM
Reviewer
Restricted Project
Differential Revision
D1255: ensure `on_complete` called for completed compute log subscriptions
Parents
R1:a05b487c54b3: Change default scrolling behavior
Branches
Unknown
Tags
Unknown