HomePhabricator

Don't use a custom keyMapper

Authored by Max Gasner <max.gasner@gmail.com> on Jul 28 2019, 9:06 PM.

Description

Don't use a custom keyMapper

Summary: Fixes https://github.com/dagster-io/dagster/issues/1617, with a potential hit to render performance. See: https://github.com/bvaughn/react-virtualized/blob/master/docs/CellMeasurer.md#prop-types-1

Test Plan: Manual

Reviewers: #ft, schrockn, bengotow

Reviewed By: #ft, schrockn, bengotow

Differential Revision: https://dagster.phacility.com/D721

Details

Committed
Max Gasner <max.gasner@gmail.com>Jul 29 2019, 3:43 PM
Reviewer
Restricted Project
Differential Revision
D721: Don't use a custom keyMapper
Parents
R1:4e5e61c75262: Better flexbox sizing for metadata entries
Branches
Unknown
Tags
Unknown