HomePhabricator

[dagit] enable multi-step re-execution via step subset selector #2453

Authored by yuhan on Fri, May 15, 6:48 AM.

Description

[dagit] enable multi-step re-execution via step subset selector #2453

Summary:
https://github.com/dagster-io/dagster/issues/2453

a few changes

  • untie the step selection from log filter
    • code-wise, ReexecuteWithData now owns
      • selectedSteps which was previously generated from Run's state logsFilter
      • query which was previously owned by GaantChart. We lifted it up b/c click event on single step will also update query now.
    • behavior-wise, click on a step will 1) select a step, 2) filter the log of this step, and 3) update the selector query. Removing the filter won't deselect the step.
  • click a selected step will deselect it, remove it from log filter, and clear the selector query
  • the "type a step subset" input will now change the selectedSteps therefore enable multi-step re-execution
    • the step selector no longer hide unselected steps by default. we now have a checkbox to give users the option to show/hide unselected steps

single step selection via single-click

arbitrary step subset selection via selector syntax

Test Plan:
click around dagit

  • playground
  • run

Reviewers: bengotow, schrockn, max

Reviewed By: schrockn

Differential Revision: https://dagster.phacility.com/D2959

Details

Committed
yuhanMon, May 18, 11:20 PM
Reviewer
schrockn
Differential Revision
D2959: [dagit] enable multi-step re-execution via step subset selector #2453
Parents
R1:655169e8ea29: Fix issue number
Branches
Unknown
Tags
Unknown