HomePhabricator

Make anonymous types in config type system have stable keys

Authored by schrockn on Nov 20 2019, 3:32 PM.

Description

Make anonymous types in config type system have stable keys

Summary:
This has been a long-standing technical liability that IMO
become intolerable with the upcoming work to persist the type system
metadata in a database. Instead of just assigning an incremental
counter to Dicts, Selectors, etc to assign key names (so that we
can do things like have the config editor work) instead this
assigns the key based on the fields passed into types.

Critically this makes it so that import order will no longer alter
the keys.

Test Plan: BK and run dagit.

Reviewers: max, alangenfeld, natekupp, bengotow

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D1458

Details

Committed
schrocknNov 20 2019, 11:37 PM
Reviewer
alangenfeld
Differential Revision
D1458: Make anonymous types in config type system have stable keys
Parents
R1:fd6c3f706e3f: Doubly nested composite failures
Branches
Unknown
Tags
Unknown