HomeElementl

Smarter dbt default argument handling

Description

Smarter dbt default argument handling

Summary:
The original implementation made every single default flag go through to every single command (because of version drift between dbt and us, we'll never know the exact set of valid flags for a given command). However, there are some common flags that we can be a bit smarter about. In particular, models, select, and exclude are well-defined and unlikely to change. With this change, if any of these are present in the default flag set, but NOT present in the function signature (e.g. run-operation does not take any of these arguments), they will not be forwarded.

I also updated the tests to use the new direct invocation stuff.

Slack link: https://dagster.slack.com/archives/C01U954MEER/p1627477307097100

Test Plan: bk

Reviewers: alangenfeld, cdecarolis

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D9121

Details

Provenance
owenAuthored on Jul 28 2021, 3:29 PM
Reviewer
alangenfeld
Differential Revision
D9121: Smarter dbt default argument handling
Parents
R1:4ccdbb18c493: delegate k8s executor config to run launcher if it isn't set, instead of…
Branches
Unknown
Tags
Unknown