Rename configDefinition to configField
7a78623dc429
Actions

Authored by schrockn on Nov 15 2019, 10:52 PM.

Description

Rename configDefinition to configField

Summary:
This is a callback to a time long, long ago where there
was a separate concept of a "ConfigDefinition" distinct from a field

Test Plan: ts, load dagit

Reviewers: alangenfeld

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D1439

Details

Committed

schrockn

Nov 15 2019, 11:40 PM

Reviewer

alangenfeld

Differential Revision

D1439: Rename configDefinition to configField

Parents

R1:02432d07bee0: Eliminate unused graphql fields on Pipeline related to config type system

Branches

Unknown

Tags

Unknown

Event Timeline

schrockn committed R1:7a78623dc429: Rename configDefinition to configField (authored by schrockn).Nov 15 2019, 11:40 PM

schrockn added an edge: D1439: Rename configDefinition to configField.

Changes (24)

Path

Size

js_modules/

dagit/

src/

SidebarSolidDefinition.tsx

__tests__/

__data__/

PIPELINE_EXPLORER_ROOT_QUERY.json

ROOT_PIPELINES_QUERY.json

SOLIDS_ROOT_QUERY.json

graph/

__data__/

airline_demo_ingest_pipeline.json

airline_demo_warehouse_pipeline.json

composition.json

fan_in_fan_out_pipeline.json

log_spew.json

many_events.json

execute/

types/

SolidSelectorQuery.ts

graph/

SolidNode.tsx

types/

PipelineGraphSolidFragment.ts

SolidNodeDefinitionFragment.ts

schema.graphql

solids/

types/

SolidCardSolidDefinitionFragment.ts

SolidsRootQuery.ts

types/

PipelineExplorerRootQuery.ts

PipelineExplorerSolidHandleFragment.ts

SidebarSolidDefinitionFragment.ts

SidebarTabbedContainerSolidFragment.ts

python_modules/

dagster-graphql/

dagster_graphql/

schema/

solids.py

dagster_graphql_tests/

graphql/

conftest.py

test_misc.py

R1:7a78623dc429

View Options

js_modules/dagit/src/SidebarSolidDefinition.tsx

View Options

js_modules/dagit/src/tests/data/PIPELINE_EXPLORER_ROOT_QUERY.json

View Options

js_modules/dagit/src/tests/data/ROOT_PIPELINES_QUERY.json

View Options

js_modules/dagit/src/tests/data/SOLIDS_ROOT_QUERY.json

View Options

js_modules/dagit/src/tests/graph/data/airline_demo_ingest_pipeline.json

View Options

js_modules/dagit/src/tests/graph/data/airline_demo_warehouse_pipeline.json

View Options

js_modules/dagit/src/tests/graph/data/composition.json

View Options

js_modules/dagit/src/tests/graph/data/fan_in_fan_out_pipeline.json

View Options

js_modules/dagit/src/tests/graph/data/log_spew.json

View Options

js_modules/dagit/src/tests/graph/data/many_events.json

View Options

js_modules/dagit/src/execute/types/SolidSelectorQuery.ts

View Options

js_modules/dagit/src/graph/SolidNode.tsx

View Options

js_modules/dagit/src/graph/types/PipelineGraphSolidFragment.ts

View Options

js_modules/dagit/src/graph/types/SolidNodeDefinitionFragment.ts

View Options

js_modules/dagit/src/schema.graphql

View Options

js_modules/dagit/src/solids/types/SolidCardSolidDefinitionFragment.ts

View Options

js_modules/dagit/src/solids/types/SolidsRootQuery.ts

View Options

js_modules/dagit/src/types/PipelineExplorerRootQuery.ts

View Options

js_modules/dagit/src/types/PipelineExplorerSolidHandleFragment.ts

View Options

js_modules/dagit/src/types/SidebarSolidDefinitionFragment.ts

View Options

js_modules/dagit/src/types/SidebarTabbedContainerSolidFragment.ts

View Options

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_misc.py

Rename configDefinition to configField7a78623dc429Actions

Description

Details

Event Timeline

Changes (24)

R1:7a78623dc429

js_modules/dagit/src/SidebarSolidDefinition.tsx

js_modules/dagit/src/__tests__/__data__/PIPELINE_EXPLORER_ROOT_QUERY.json

js_modules/dagit/src/__tests__/__data__/ROOT_PIPELINES_QUERY.json

js_modules/dagit/src/__tests__/__data__/SOLIDS_ROOT_QUERY.json

js_modules/dagit/src/__tests__/graph/__data__/airline_demo_ingest_pipeline.json

js_modules/dagit/src/__tests__/graph/__data__/airline_demo_warehouse_pipeline.json

js_modules/dagit/src/__tests__/graph/__data__/composition.json

js_modules/dagit/src/__tests__/graph/__data__/fan_in_fan_out_pipeline.json

js_modules/dagit/src/__tests__/graph/__data__/log_spew.json

js_modules/dagit/src/__tests__/graph/__data__/many_events.json

js_modules/dagit/src/execute/types/SolidSelectorQuery.ts

js_modules/dagit/src/graph/SolidNode.tsx

js_modules/dagit/src/graph/types/PipelineGraphSolidFragment.ts

js_modules/dagit/src/graph/types/SolidNodeDefinitionFragment.ts

js_modules/dagit/src/schema.graphql

js_modules/dagit/src/solids/types/SolidCardSolidDefinitionFragment.ts

js_modules/dagit/src/solids/types/SolidsRootQuery.ts

js_modules/dagit/src/types/PipelineExplorerRootQuery.ts

js_modules/dagit/src/types/PipelineExplorerSolidHandleFragment.ts

js_modules/dagit/src/types/SidebarSolidDefinitionFragment.ts

js_modules/dagit/src/types/SidebarTabbedContainerSolidFragment.ts

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/conftest.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_misc.py

Rename configDefinition to configField
7a78623dc429
Actions

js_modules/dagit/src/tests/data/PIPELINE_EXPLORER_ROOT_QUERY.json

js_modules/dagit/src/tests/data/ROOT_PIPELINES_QUERY.json

js_modules/dagit/src/tests/data/SOLIDS_ROOT_QUERY.json

js_modules/dagit/src/tests/graph/data/airline_demo_ingest_pipeline.json

js_modules/dagit/src/tests/graph/data/airline_demo_warehouse_pipeline.json

js_modules/dagit/src/tests/graph/data/composition.json

js_modules/dagit/src/tests/graph/data/fan_in_fan_out_pipeline.json

js_modules/dagit/src/tests/graph/data/log_spew.json

js_modules/dagit/src/tests/graph/data/many_events.json