HomePhabricator

Refactor compute log watching contextmanager to move to the compute log manager

Authored by prha on Mar 24 2020, 8:17 PM.

Description

Refactor compute log watching contextmanager to move to the compute log manager

Summary:
This recommits D2301, which was reverted due to failures in the windows tests.

This diff fixes those failures by skipping compute log tests when the legacy windows stdio
is not supported (windows python 3.6+, with env var PYTHONLEGACYWINDOWSSTDIO not set.

It also changes some tests that did not handle the difference in windows line separators, and
fixed the tail implementation for windows by swallowing exceptions caused by pytest's stdout
routing.

Test Plan:
Ran test suite in buildkite / azure pipelines
(see https://dev.azure.com/elementl/dagster/_build/results?buildId=6739&view=results)

Reviewers: alangenfeld, schrockn

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D2335

Details

Committed
prhaMar 25 2020, 4:11 PM
Reviewer
alangenfeld
Differential Revision
D2335: Refactor compute log watching contextmanager to move to the compute log manager
Parents
R1:146060f4a827: inner_plan_iterator diff bug fixes
Branches
Unknown
Tags
Unknown