HomePhabricator

[#2220-3] rename runtime_type => dagster_type outside core.definition - args…

Authored by yuhan on Mar 6 2020, 10:06 PM.

Description

[#2220-3] rename runtime_type => dagster_type outside core.definition - args and callsites

Summary:
Issue: https://github.com/dagster-io/dagster/issues/2220
Deprecated the following args and their call sites

Warings:

  • runtime_type => dagster_type in StepInput and StepOutput

Breaking changes:

  • runtime_type => dagster_type in IntermediateStore.[set|get]_[object|value]

^ Most IntermediateStore.[set/get]_[object/value] are called without argument names. So I decided to rename it without keeping the old name, as there may be fewer breaking changes when just renaming the arg.

Test Plan:

  • grep: the only runtime_type stuff left in the codebase is graphql schema related

https://dagster.phacility.com/P37

  • pytest
  • ran example pipelines in dagit
  • BK

Reviewers: prha, schrockn

Reviewed By: prha

Differential Revision: https://dagster.phacility.com/D2204

Details