HomePhabricator

pin ecdsa (moto dep), which has import resolving issues

Authored by prha on Wed, Nov 6, 8:56 PM.

Description

pin ecdsa (moto dep), which has import resolving issues

Summary:
I'm not 100% sure why the import started failing, but there's some dark and nefarious python dependency resolution evil happening here.

@natekupp, @max, feel free to chime in on why this solution is bad...

Here's what I think is going on...

  • ecdsa package releases 0.14, which removes their internal copy-pastad version of six and actually uses the six module
  • In our tests, we pip install six@1.13, which does export the requested resource
  • For some reason, in the ecdsa package, the import fails.

I ignored all that and just pinned ecdsa to 0.13 which has the internally bundled version of six so tests would stop failing.

Test Plan: bk

Reviewers: #ft, natekupp

Reviewed By: #ft, natekupp

Subscribers: natekupp, max

Differential Revision: https://dagster.phacility.com/D1373

Details