Paths

Table of Contentst

Diffusion dagster 6af4c12ea15e

[crag] fix snapshots handling composed @graph
6af4c12ea15e
Actions

Description

[crag] fix snapshots handling composed @graph

Summary:
Snapshot code was still coded against CompositeSolidDefinition checks without a fall-through so

fix it
re-arrange it to have a check.failed for unhandled node types
rename getter to node since it has graphs and solids

Test Plan: added tests

Reviewers: cdecarolis, owen, yuhan, prha, sandyryza

Reviewed By: sandyryza

Differential Revision: https://dagster.phacility.com/D8943

Details

Provenance

alangenfeld

Authored on Jul 19 2021, 3:31 PM

Reviewer

sandyryza

Differential Revision

D8943: [crag] fix snapshots handling composed @graph

Parents

R1:7ceb7c54e811: Update dagster-instance.mdx (#4388)

Branches

Unknown

Tags

Unknown

Event Timeline

alangenfeld committed R1:6af4c12ea15e: [crag] fix snapshots handling composed @graph (authored by alangenfeld).Jul 22 2021, 4:45 PM

alangenfeld added an edge: D8943: [crag] fix snapshots handling composed @graph.

Changes (12)

Path

Size

python_modules/

dagster-graphql/

dagster_graphql/

schema/

solids.py

dagster_graphql_tests/

graphql/

setup.py

snapshots/

snap_test_all_snapshot_ids.py

snap_test_solids.py

test_composites.py

dagster/

cli/

pipeline.py

core/

host_representation/

snap/

dagster_tests/

core_tests/

graph_tests/

test_graph.py

snap_tests/

test_pipeline_snap.py

R1:6af4c12ea15e

View Options

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_all_snapshot_ids.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_solids.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_composites.py

View Options

python_modules/dagster/dagster/cli/pipeline.py

View Options

python_modules/dagster/dagster/core/host_representation/pipeline_index.py

View Options

python_modules/dagster/dagster/core/host_representation/represented.py

View Options

python_modules/dagster/dagster/core/snap/pipeline_snapshot.py

View Options

python_modules/dagster/dagster/core/snap/solid.py

View Options

python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py

View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/test_pipeline_snap.py

[crag] fix snapshots handling composed @graph6af4c12ea15eActions

Description

Details

Event Timeline

Changes (12)

R1:6af4c12ea15e

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_all_snapshot_ids.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_solids.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_composites.py

python_modules/dagster/dagster/cli/pipeline.py

python_modules/dagster/dagster/core/host_representation/pipeline_index.py

python_modules/dagster/dagster/core/host_representation/represented.py

python_modules/dagster/dagster/core/snap/pipeline_snapshot.py

python_modules/dagster/dagster/core/snap/solid.py

python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py

python_modules/dagster/dagster_tests/core_tests/snap_tests/test_pipeline_snap.py

[crag] fix snapshots handling composed @graph
6af4c12ea15e
Actions