HomePhabricator

Show error toast on termination PythonError

Description

Show error toast on termination PythonError

Summary:
When a Python error is raised when terminating a run, the "Terminate" button doesn't appear to do anything and no error is surfaced.

Resolve this by ensuring that the PythonError is also handled in the mutation.

Resolves #2688

Test Plan: Run an intentionally slow pipeline, with a raise Exception('oh no') in the termination codepath. Click "Terminate", verify that the error toast appears.

Reviewers: catherinewu, bengotow, prha

Reviewed By: prha

Differential Revision: https://dagster.phacility.com/D4452

Details

Provenance
dishAuthored on Sep 17 2020, 1:51 PM
Reviewer
prha
Differential Revision
D4452: Show error toast on termination PythonError
Parents
R1:e243f7c1cbb5: 0.9.9.pre0
Branches
Unknown
Tags
Unknown