HomeElementl

Add run IDs to the list of runs in grpcrunlauncher used for test cleanup, even…

Description

Add run IDs to the list of runs in grpcrunlauncher used for test cleanup, even if the launch failed

Summary:
This is important because we use this list for test cleanup to wait for any servers that launched runs (to avoid tempdir contention issues). So tests in which a launch failed might fail to wait for the server that launched the failed run to die before tearing down, causing flakiness (https://dev.azure.com/elementl/dagster/_build/results?buildId=9742&view=logs&j=97c9b631-cb7a-5c89-c2a5-acb43d4227bd&t=256f5766-8906-5a25-01de-b83c5e4e5216).

That said, we should really look into removing this cleanup logic from the run launcher and putting it somewhere better.

Test Plan: BK + Azure

Reviewers: alangenfeld, max, prha, schrockn

Reviewed By: max

Differential Revision: https://dagster.phacility.com/D4968

Details