HomePhabricator

[dagit] Show syntax errors in config editor

Authored by Sashank Thupukari <s@thupukari.com> on Jul 17 2019, 11:00 PM.

Description

[dagit] Show syntax errors in config editor

Summary:
Fixes issue in: https://github.com/dagster-io/dagster/issues/1571

When entering config in dagit, if you enter config that is not a dict, the validation error is caught at the wrong layer and is displayed as a "GraphQL Error".

Instead, we can check if the config is not a dict client side and display a syntax error

Test Plan:
before:

after:

Reviewers: #ft, max

Reviewed By: #ft, max

Subscribers: max

Differential Revision: https://dagster.phacility.com/D656

Details

Committed
Sashank Thupukari <s@thupukari.com>Jul 18 2019, 8:26 PM
Reviewer
Restricted Project
Differential Revision
D656: [dagit] Show syntax errors in config editor
Parents
R1:89a0379d89c4: Remove unnecessary log messages
Branches
Unknown
Tags
Unknown