Paths

Table of Contentst

Diffusion dagster 4bcaa2828860

Remove usage of six
4bcaa2828860
Actions

Tags

None

Subscribers

None

Description

Remove usage of six

Summary:
Removes all usage of six from the codebase.

Since this involves replacing six.ensure_string and six.ensure_binary, this diff also adopts the convention that we use explicit .decode("utf-8") and .encode("utf-8") everywhere, although I am inclined to change this to bare .decode() and .encode() everywhere since utf-8 is always the default. Thoughts?

Test Plan: unit

Reviewers: alangenfeld, max

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D5944

Details

Provenance

Authored on Jan 12 2021, 11:29 PM

Reviewer

Differential Revision

D5944: Remove usage of six

Parents

R1:44ac12ed0195: [dagit] Use tabular-nums spacing on TimestampDisplay

Branches

Unknown

Tags

Unknown

Event Timeline

• nate committed R1:4bcaa2828860: Remove usage of six (authored by • nate).Jan 13 2021, 5:32 PM

• nate added an edge: D5944: Remove usage of six.

Changes (83)

Path

Size

.buildkite/

dagster-buildkite/

dagster_buildkite/

steps/

docs/

test_doc_build.py

examples/

airline_demo/

airline_demo_tests/

unit_tests/

test_unzip_file_handle.py

dbt_example/

dbt_example_tests/

docs_snippets/

docs_snippets/

legacy/

data_science/

download_file.py

legacy_examples/

dagster_examples_tests/

event_pipeline_demo_tests/

integration_tests/

python_modules/

dagster-k8s-test-infra/

dagster_k8s_test_infra/

integration_utils.py

python_modules/

automation/

automation/

docs/

check_library_docs.py

parse_dataproc_configs.py

parse_spark_configs.py

dagit/

dagit/

format_error.py

dagster-test/

dagster_test/

test_project/

toys/

error_monster.py

dagster/

dagster/

config/

core/

code_pointer.py

definitions/

execution/

storage/

event_log/

sql_event_log.py

intermediate_storage.py

runs/

sql_run_storage.py

schedules/

sql_schedule_storage.py

types/

dagster_type.py

serdes/

utils/

indenting_printer.py

test/

postgres_instance.py

dagster_tests/

cli_tests/

test_version.py

core_tests/

runtime_types_tests/

config_schema_tests/

test_config_schema.py

storage_tests/

test_defensive_row_unpack.py

test_local_file_cache.py

test_local_file_manager.py

test_versioned_execution_plan.py

general_tests/

compat_tests/

test_back_compat.py

utils_tests/

test_backoff.py

libraries/

dagster-airflow/

dagster_airflow/

dagster-aws/

dagster_aws/

athena/

emr/

redshift/

utils/

mrjob/

dagster_aws_tests/

emr_tests/

s3_tests/

test_compute_log_manager.py

test_file_handle_to_s3.py

test_s3_file_cache.py

test_s3_file_manager.py

dagster-azure/

dagster_azure_tests/

adls2_tests/

test_adls2_file_cache.py

test_adls2_file_manager.py

blob_tests/

test_compute_log_manager.py

dagster-celery/

dagster_celery_tests/

dagster-cron/

dagster_cron/

cron_scheduler.py

dagster-dbt/

dagster_dbt/

cli/

dagster_dbt_tests/

rpc/

dagster-gcp/

dagster_gcp/

bigquery/

dagster_gcp_tests/

dataproc_tests/

test_resources.py

gcs_tests/

test_compute_log_manager.py

test_gcs_file_manager.py

dagster-github/

dagster_github_tests/

test_resources.py

dagster-k8s/

dagster_k8s/

dagster-postgres/

dagster_postgres/

dagster-shell/

dagster_shell/

dagster_shell_tests/

dagster-ssh/

dagster_ssh/

dagster_ssh_tests/

test_resources.py

dagstermill/

dagstermill/

scripts/

install_dev_python_modules.py

R1:4bcaa2828860

.buildkite/dagster-buildkite/dagster_buildkite/steps/trigger.py

Loading...

.buildkite/dagster-buildkite/dagster_buildkite/utils.py

Loading...

docs/test_doc_build.py

Loading...

examples/airline_demo/airline_demo_tests/conftest.py

Loading...

examples/airline_demo/airline_demo_tests/unit_tests/test_unzip_file_handle.py

Loading...

examples/dbt_example/dbt_example_tests/conftest.py

Loading...

examples/docs_snippets/docs_snippets/legacy/data_science/download_file.py

Loading...

examples/legacy_examples/dagster_examples_tests/event_pipeline_demo_tests/conftest.py

Loading...

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

Loading...

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/integration_utils.py

Loading...

python_modules/automation/automation/docs/check_library_docs.py

Loading...

python_modules/automation/automation/git.py

Loading...

python_modules/automation/automation/parse_dataproc_configs.py

Loading...

python_modules/automation/automation/parse_spark_configs.py

Loading...

python_modules/automation/automation/printer.py

Loading...

python_modules/dagit/dagit/cli.py

Loading...

python_modules/dagit/dagit/debug.py

Loading...

python_modules/dagit/dagit/format_error.py

Loading...

python_modules/dagster-test/dagster_test/test_project/init.py

Loading...

python_modules/dagster-test/dagster_test/toys/error_monster.py

Loading...

python_modules/dagster/dagster/config/field_utils.py

Loading...

python_modules/dagster/dagster/core/code_pointer.py

Loading...

python_modules/dagster/dagster/core/debug.py

Loading...

python_modules/dagster/dagster/core/definitions/graph.py

Loading...

python_modules/dagster/dagster/core/definitions/inference.py

Loading...

python_modules/dagster/dagster/core/definitions/pipeline.py

Loading...

python_modules/dagster/dagster/core/definitions/preset.py

Loading...

python_modules/dagster/dagster/core/definitions/utils.py

Loading...

python_modules/dagster/dagster/core/errors.py

Loading...

python_modules/dagster/dagster/core/execution/stats.py

Loading...

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py

Loading...

python_modules/dagster/dagster/core/storage/intermediate_storage.py

Loading...

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

Loading...

python_modules/dagster/dagster/core/storage/schedules/sql_schedule_storage.py

Loading...

python_modules/dagster/dagster/core/types/dagster_type.py

Loading...

python_modules/dagster/dagster/serdes/init.py

Loading...

python_modules/dagster/dagster/utils/init.py

Loading...

python_modules/dagster/dagster/utils/backoff.py

Loading...

python_modules/dagster/dagster/utils/indenting_printer.py

Loading...

python_modules/dagster/dagster/utils/test/postgres_instance.py

Loading...

python_modules/dagster/dagster_tests/cli_tests/test_version.py

Loading...

python_modules/dagster/dagster_tests/conftest.py

Loading...

python_modules/dagster/dagster_tests/core_tests/runtime_types_tests/config_schema_tests/test_config_schema.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_defensive_row_unpack.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_local_file_cache.py

Loading...

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_local_file_manager.py

Loading...

python_modules/dagster/dagster_tests/core_tests/test_versioned_execution_plan.py

Loading...

python_modules/dagster/dagster_tests/general_tests/compat_tests/test_back_compat.py

Loading...

python_modules/dagster/dagster_tests/general_tests/utils_tests/test_backoff.py

Loading...

python_modules/dagster/setup.py

Loading...

python_modules/libraries/dagster-airflow/dagster_airflow/cli.py

Loading...

python_modules/libraries/dagster-airflow/setup.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws/athena/resources.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws/emr/emr.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws/redshift/resources.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws/utils/mrjob/log4j.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws_tests/emr_tests/test_emr.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_compute_log_manager.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_file_handle_to_s3.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_s3_file_cache.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_s3_file_manager.py

Loading...

python_modules/libraries/dagster-azure/dagster_azure_tests/adls2_tests/test_adls2_file_cache.py

Loading...

python_modules/libraries/dagster-azure/dagster_azure_tests/adls2_tests/test_adls2_file_manager.py

Loading...

python_modules/libraries/dagster-azure/dagster_azure_tests/blob_tests/test_compute_log_manager.py

Loading...

python_modules/libraries/dagster-celery/dagster_celery_tests/test_config.py

Loading...

python_modules/libraries/dagster-cron/dagster_cron/cron_scheduler.py

Loading...

python_modules/libraries/dagster-dbt/dagster_dbt/cli/utils.py

Loading...

python_modules/libraries/dagster-dbt/dagster_dbt_tests/rpc/conftest.py

Loading...

python_modules/libraries/dagster-gcp/dagster_gcp/bigquery/solids.py

Loading...

python_modules/libraries/dagster-gcp/dagster_gcp_tests/dataproc_tests/test_resources.py

Loading...

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_compute_log_manager.py

Loading...

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_gcs_file_manager.py

Loading...

python_modules/libraries/dagster-github/dagster_github_tests/test_resources.py

Loading...

python_modules/libraries/dagster-k8s/dagster_k8s/client.py

Loading...

python_modules/libraries/dagster-k8s/dagster_k8s/job.py

Loading...

python_modules/libraries/dagster-postgres/dagster_postgres/utils.py

Loading...

python_modules/libraries/dagster-shell/dagster_shell/utils.py

Loading...

python_modules/libraries/dagster-shell/dagster_shell_tests/conftest.py

Loading...

python_modules/libraries/dagster-ssh/dagster_ssh/resources.py

Loading...

python_modules/libraries/dagster-ssh/dagster_ssh_tests/test_resources.py

Loading...

python_modules/libraries/dagstermill/dagstermill/manager.py

Loading...

python_modules/libraries/dagstermill/setup.py

Loading...

scripts/install_dev_python_modules.py

Loading...