Paths

Table of Contentst

Diffusion dagster 4bbdc40cf037

[dagit] Add an id field to Mode
4bbdc40cf037
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

[dagit] Add an id field to Mode

Summary:
Now that we are querying mode more aggressively on Pipeline, we are ending up with more cases where the cached object in Apollo appears to be treated as a mismatch, and extra queries are performed. It appears to be because Mode does not have an ID, e.g. Apollo does not match the objects based on the name field alone.

Ideally this change will result in fewer network queries of the root repository query and search bootstrap query during simple navigation of Dagit.

Test Plan: View a pipeline in Dagit, click "Playground". Verify that the RootRepositoriesQuery and SearchBootstrapQuery are not requested. (In master, they currently are.)

Reviewers: bengotow, sandyryza, prha, dgibson

Reviewed By: prha, dgibson

Differential Revision: https://dagster.phacility.com/D8495

Details

Provenance

Authored on Jun 19 2021, 1:03 PM

Reviewer

Differential Revision

D8495: [dagit] Add an id field to Mode

Parents

R1:f331e0eafafe: Use the EcsRunLauncher in the reference deployment

Branches

Unknown

Tags

Unknown

Event Timeline

• dish committed R1:4bbdc40cf037: [dagit] Add an id field to Mode (authored by • dish).Jun 24 2021, 5:43 PM

• dish added an edge: D8495: [dagit] Add an id field to Mode.

Changes (20)

Path

Size

js_modules/

dagit/

packages/

core/

src/

execute/

PipelineExecutionRoot.tsx

types/

ExecutionSessionContainerPipelineFragment.ts

PipelineExecutionRootQuery.ts

graphql/

nav/

FlatContentList.tsx

types/

pipelines/

PipelineTable.tsx

SidebarPipelineInfo.tsx

types/

PipelineExplorerFragment.ts

PipelineExplorerRootQuery.ts

PipelineTableFragment.ts

SidebarPipelineInfoFragment.ts

SidebarTabbedContainerPipelineFragment.ts

search/

types/

SearchBootstrapQuery.ts

useRepoSearch.tsx

workspace/

WorkspaceContext.tsx

types/

RepositoryPipelinesListQuery.ts

RootRepositoriesQuery.ts

python_modules/

dagster-graphql/

dagster_graphql/

schema/

pipelines/

R1:4bbdc40cf037

js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx

Loading...

js_modules/dagit/packages/core/src/execute/types/ExecutionSessionContainerPipelineFragment.ts

Loading...

js_modules/dagit/packages/core/src/execute/types/PipelineExecutionRootQuery.ts

Loading...

js_modules/dagit/packages/core/src/graphql/schema.graphql

Loading...

js_modules/dagit/packages/core/src/nav/FlatContentList.tsx

Loading...

js_modules/dagit/packages/core/src/nav/types/NavQuery.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/PipelineTable.tsx

Loading...

js_modules/dagit/packages/core/src/pipelines/SidebarPipelineInfo.tsx

Loading...

js_modules/dagit/packages/core/src/pipelines/types/PipelineExplorerFragment.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/PipelineExplorerRootQuery.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/PipelineTableFragment.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/SidebarPipelineInfoFragment.ts

Loading...

js_modules/dagit/packages/core/src/pipelines/types/SidebarTabbedContainerPipelineFragment.ts

Loading...

js_modules/dagit/packages/core/src/search/types/SearchBootstrapQuery.ts

Loading...

js_modules/dagit/packages/core/src/search/useRepoSearch.tsx

Loading...

js_modules/dagit/packages/core/src/workspace/WorkspaceContext.tsx

Loading...

js_modules/dagit/packages/core/src/workspace/types/RepositoryPipelinesListQuery.ts

Loading...

js_modules/dagit/packages/core/src/workspace/types/RootRepositoriesQuery.ts

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/mode.py

Loading...

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py

Loading...