[crag] Add mode to the pipeline runs filter
49d8ab683801
Actions

Description

[crag] Add mode to the pipeline runs filter

Summary: This diff adds mode to the PipelineRunsFilter object, adds a schema entry for mode in the runs table, and a method for data migration to retrieve the mode off of the pipeline run and add it to the corresponding row in the runs table.

Test Plan: Added backcompat tests for pg and sqlite, as well as tests to the run storage battery.

Reviewers: sandyryza, dish, alangenfeld, yuhan, prha

Reviewed By: prha

Differential Revision: https://dagster.phacility.com/D8629

Details

Provenance

Chris DeCarolis <cdguitar817@gmail.com>

Authored on Jul 6 2021, 5:48 PM

Reviewer

• prha

Differential Revision

D8629: [crag] Add mode to the pipeline runs filter

Parents

R1:ec6992cfa109: feat!: rename queuedRunCoordinator to runCoordinator in Helm

Branches

Unknown

Tags

Unknown

Event Timeline

Chris DeCarolis <cdguitar817@gmail.com> committed R1:49d8ab683801: [crag] Add mode to the pipeline runs filter (authored by Chris DeCarolis <cdguitar817@gmail.com>).Jul 8 2021, 1:54 PM

Chris DeCarolis <cdguitar817@gmail.com> added an edge: D8629: [crag] Add mode to the pipeline runs filter.

Changes (28)

Path

Size

python_modules/

dagster-graphql/

dagster_graphql/

schema/

inputs.py

dagster/

core/

storage/

runs/

dagster_tests/

core_tests/

storage_tests/

utils/

run_storage.py

general_tests/

compat_tests/

snapshot_0_11_16_pre_add_mode_column

sqlite

history

runs

	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/
	snapshot_0_11_0_pre_asset_details/	sqlite/	history/

runs.db

runs/

index.db-shm

	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/	runs/
	snapshot_0_10_6_add_bulk_actions_table/	sqlite/	history/

	3f76caec-7d8d-4dcc-83c3-1d92469d7320.db
	runs.db

	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/	runs/
	test_execution_plan_snapshots/	0_11_1/	history/	runs/

index.db

test_back_compat.py

	general_tests/

	compat_tests/	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/
	core_tests/	storage_tests/	compat_tests/	snapshot_0_9_16_asset_key_structure/

runs.db-shm

	compat_tests/	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/	runs/
		core_tests/	storage_tests/	compat_tests/	snapshot_0_9_16_asset_key_structure/

	3f76caec-7d8d-4dcc-83c3-1d92469d7320.db-shm
	event_log.db-shm

	dagster/	dagster/	core/	storage/	runs/	sqlite/	alembic/	versions/
				libraries/	dagster-postgres/	dagster_postgres/	alembic/	versions/

	7f2b1a4ca7a5_add_column_mode.py
	1ebdd7a9686f_add_step_key_pipeline_name.py

libraries/

	dagster-mysql/	dagster_mysql/	alembic/	versions/
	dagster-postgres/	dagster_postgres/	alembic/	versions/

	45fa602c43dc_add_column_mode.py
	1ebdd7a9686f_add_step_key_pipeline_name.py

dagster-postgres/

dagster_postgres/

alembic/

versions/

	ddcc6d7244c6_add_column_mode.py
	1ebdd7a9686f_add_step_key_pipeline_name.py

dagster_postgres_tests/

compat_tests/

snapshot_0_11_16_pre_add_mode_column

postgres

pg_dump.txt

test_back_compat.py

	python_modules/	dagster/	dagster_tests/	general_tests/	compat_tests/

	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/
	.buildkite/	dagster-buildkite/	dagster_buildkite/

	runs.db-wal
	__init__.py

	snapshot_0_11_16_pre_add_mode_column/	sqlite/	history/	runs/
		.buildkite/	dagster-buildkite/	dagster_buildkite/

	3f76caec-7d8d-4dcc-83c3-1d92469d7320.db-wal
	__init__.py

	index.db-wal
	__init__.py

R1:49d8ab683801

View Options

python_modules/dagster-graphql/dagster_graphql/schema/inputs.py

View Options

python_modules/dagster/dagster/core/storage/pipeline_run.py

View Options

python_modules/dagster/dagster/core/storage/runs/in_memory.py

View Options

python_modules/dagster/dagster/core/storage/runs/migration.py

View Options

python_modules/dagster/dagster/core/storage/runs/schema.py

View Options

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

View Options

python_modules/dagster/dagster/core/storage/runs/sqlite/alembic/versions/7f2b1a4ca7a5_add_column_mode.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs.db

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs.db-shm

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs.db-wal

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/3f76caec-7d8d-4dcc-83c3-1d92469d7320.db

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/3f76caec-7d8d-4dcc-83c3-1d92469d7320.db-shm

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/3f76caec-7d8d-4dcc-83c3-1d92469d7320.db-wal

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/index.db

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/index.db-shm

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/index.db-wal

View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/test_back_compat.py

View Options

python_modules/libraries/dagster-mysql/dagster_mysql/alembic/versions/45fa602c43dc_add_column_mode.py

View Options

python_modules/libraries/dagster-postgres/dagster_postgres/alembic/versions/ddcc6d7244c6_add_column_mode.py

View Options

python_modules/libraries/dagster-postgres/dagster_postgres_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/postgres/pg_dump.txt

View Options

python_modules/libraries/dagster-postgres/dagster_postgres_tests/compat_tests/test_back_compat.py

[crag] Add mode to the pipeline runs filter49d8ab683801Actions

Description

Details

Event Timeline

Changes (28)

R1:49d8ab683801

python_modules/dagster-graphql/dagster_graphql/schema/inputs.py

python_modules/dagster/dagster/core/storage/pipeline_run.py

python_modules/dagster/dagster/core/storage/runs/in_memory.py

python_modules/dagster/dagster/core/storage/runs/migration.py

python_modules/dagster/dagster/core/storage/runs/schema.py

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

python_modules/dagster/dagster/core/storage/runs/sqlite/alembic/versions/7f2b1a4ca7a5_add_column_mode.py

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs.db

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs.db-shm

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs.db-wal

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/3f76caec-7d8d-4dcc-83c3-1d92469d7320.db

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/3f76caec-7d8d-4dcc-83c3-1d92469d7320.db-shm

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/3f76caec-7d8d-4dcc-83c3-1d92469d7320.db-wal

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/index.db

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/index.db-shm

python_modules/dagster/dagster_tests/general_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/sqlite/history/runs/index.db-wal

python_modules/dagster/dagster_tests/general_tests/compat_tests/test_back_compat.py

python_modules/libraries/dagster-mysql/dagster_mysql/alembic/versions/45fa602c43dc_add_column_mode.py

python_modules/libraries/dagster-postgres/dagster_postgres/alembic/versions/ddcc6d7244c6_add_column_mode.py

python_modules/libraries/dagster-postgres/dagster_postgres_tests/compat_tests/snapshot_0_11_16_pre_add_mode_column/postgres/pg_dump.txt

python_modules/libraries/dagster-postgres/dagster_postgres_tests/compat_tests/test_back_compat.py

[crag] Add mode to the pipeline runs filter
49d8ab683801
Actions