Diffusion dagster 44c34c21efd9

[3/n init_resources] Resource initialization refactor
44c34c21efd9
Actions

Description

[3/n init_resources] Resource initialization refactor

Summary:
This diff refactors the existing code path for resource initialization.

Makes various top level args Noneable on the resource initialization manager.
Adds a new config wrapper around resource config.

Test Plan: Changed tests to reflect new resource config wrapper.

Reviewers: sandyryza, alangenfeld, max

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D6513

Details

Provenance

Chris DeCarolis <cdguitar817@gmail.com>

Authored on Mar 2 2021, 3:48 PM

Reviewer

alangenfeld

Differential Revision

D6513: [3/n init_resources] Resource initialization refactor

Parents

R1:fdad25e72a27: Remove unnecessary whitespace removal in Helm templating

Branches

Unknown

Tags

Unknown

Reverted By

R1:a383ce21c134: Revert "[4/n init_resources] init_resources context manager" and Revert "[3/n…

Event Timeline

Chris DeCarolis <cdguitar817@gmail.com> committed R1:44c34c21efd9: [3/n init_resources] Resource initialization refactor (authored by Chris DeCarolis <cdguitar817@gmail.com>).Mar 4 2021, 1:18 AM

Chris DeCarolis <cdguitar817@gmail.com> added an edge: D6513: [3/n init_resources] Resource initialization refactor.

Chris DeCarolis <cdguitar817@gmail.com> added a reverting change: R1:a383ce21c134: Revert "[4/n init_resources] init_resources context manager" and Revert "[3/n….Mar 4 2021, 3:34 AM

Changes (20)

Path

Size

python_modules/

dagster/

core/

execution/

context/

init.py

logger.py

system.py

context_creation_pipeline.py

plan/

storage/

system_config/

dagster_tests/

core_tests/

execution_tests/

test_memoized_dev_loop.py

system_config_tests/

test_system_config.py

test_composites.py

test_logging.py

test_pipeline_init.py

test_resolve_versions.py

general_tests/

utils_tests/

log_tests/

test_json_logging.py

test_single_handler.py

libraries/

dagstermill/

manager.py

R1:44c34c21efd9

View Options

python_modules/dagster/dagster/core/execution/context/init.py

View Options

python_modules/dagster/dagster/core/execution/context/logger.py

View Options

python_modules/dagster/dagster/core/execution/context/system.py

View Options

python_modules/dagster/dagster/core/execution/context_creation_pipeline.py

View Options

python_modules/dagster/dagster/core/execution/plan/inputs.py

View Options

python_modules/dagster/dagster/core/execution/resolve_versions.py

View Options

python_modules/dagster/dagster/core/execution/resources_init.py

View Options

python_modules/dagster/dagster/core/execution/results.py

View Options

python_modules/dagster/dagster/core/log_manager.py

View Options

python_modules/dagster/dagster/core/storage/system_storage.py

View Options

python_modules/dagster/dagster/core/system_config/objects.py

View Options

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_memoized_dev_loop.py

View Options

python_modules/dagster/dagster_tests/core_tests/system_config_tests/test_system_config.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_composites.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_logging.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_pipeline_init.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_resolve_versions.py

View Options

python_modules/dagster/dagster_tests/general_tests/utils_tests/log_tests/test_json_logging.py

View Options

python_modules/dagster/dagster_tests/general_tests/utils_tests/log_tests/test_single_handler.py

View Options

python_modules/libraries/dagstermill/dagstermill/manager.py

[3/n init_resources] Resource initialization refactor44c34c21efd9Actions

Description

Details

Event Timeline

Changes (20)

R1:44c34c21efd9

python_modules/dagster/dagster/core/execution/context/init.py

python_modules/dagster/dagster/core/execution/context/logger.py

python_modules/dagster/dagster/core/execution/context/system.py

python_modules/dagster/dagster/core/execution/context_creation_pipeline.py

python_modules/dagster/dagster/core/execution/plan/inputs.py

python_modules/dagster/dagster/core/execution/resolve_versions.py

python_modules/dagster/dagster/core/execution/resources_init.py

python_modules/dagster/dagster/core/execution/results.py

python_modules/dagster/dagster/core/log_manager.py

python_modules/dagster/dagster/core/storage/system_storage.py

python_modules/dagster/dagster/core/system_config/objects.py

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_memoized_dev_loop.py

python_modules/dagster/dagster_tests/core_tests/system_config_tests/test_system_config.py

python_modules/dagster/dagster_tests/core_tests/test_composites.py

python_modules/dagster/dagster_tests/core_tests/test_logging.py

python_modules/dagster/dagster_tests/core_tests/test_pipeline_init.py

python_modules/dagster/dagster_tests/core_tests/test_resolve_versions.py

python_modules/dagster/dagster_tests/general_tests/utils_tests/log_tests/test_json_logging.py

python_modules/dagster/dagster_tests/general_tests/utils_tests/log_tests/test_single_handler.py

python_modules/libraries/dagstermill/dagstermill/manager.py

[3/n init_resources] Resource initialization refactor
44c34c21efd9
Actions