HomePhabricator

Add grpc-health-probe

Description

Add grpc-health-probe

Summary:
Uses grpcio-health-check to add the health checking protocol to the grpc server. Then adds a client that can be invoked in the dagster cli.

Closes https://github.com/dagster-io/dagster/issues/3002

Test Plan:
TODO: add a failing test

Integrations, manual helm install and check that liveness probe is active

Locally:

dagster api grpc --port 3030 &

dagster api grpc-health-check --port 3030
# $? == 0

dagster api grpc-health-check --port 3031
# $? == 1

Reviewers: nate, catherinewu, alangenfeld, dgibson

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D4776

Details

Provenance
johannAuthored on Oct 21 2020, 1:55 AM
Reviewer
alangenfeld
Differential Revision
D4776: Add grpc-health-probe
Parents
R1:4a3fbbf9aa6e: Fixes typo. (RpcDbt -> DbtRpc)
Branches
Unknown
Tags
Unknown