[RFC] Errors in daemon heartbeats
42aa8f151a4d
Actions

Description

[RFC] Errors in daemon heartbeats

Summary:
Catch exceptions in run_iteration and include them in the heartbeats. DaemonStatus.healthy now implies that there both has been and recent heartbeat and it was without an error

Some questions are inline re: serialization of exceptions and Heartbeat/HeartbeatInfo into the db

Test Plan: Unit

Reviewers: dgibson, prha

Reviewed By: dgibson

Differential Revision: https://dagster.phacility.com/D5626

Details

Provenance

johann

Authored on Dec 15 2020, 8:23 PM

Reviewer

dgibson

Differential Revision

D5626: [RFC] Errors in daemon heartbeats

Parents

R1:28a58c474f33: fix place where we were yielding inside a user_code_error_boundary

Branches

Unknown

Tags

Unknown

Event Timeline

johann committed R1:42aa8f151a4d: [RFC] Errors in daemon heartbeats (authored by johann).Dec 22 2020, 5:09 PM

johann added an edge: D5626: [RFC] Errors in daemon heartbeats.

Changes (9)

Path

Size

python_modules/

dagster/

core/

storage/

runs/

daemon/

dagster_tests/

core_tests/

storage_tests/

utils/

run_storage.py

daemon_tests/

test_dagster_daemon.py

test_dagster_daemon_health.py

libraries/

dagster-postgres/

dagster_postgres/

run_storage/

run_storage.py

R1:42aa8f151a4d

View Options

python_modules/dagster/dagster/core/storage/runs/schema.py

View Options

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

View Options

python_modules/dagster/dagster/daemon/controller.py

View Options

python_modules/dagster/dagster/daemon/daemon.py

View Options

python_modules/dagster/dagster/daemon/types.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py

View Options

python_modules/dagster/dagster_tests/daemon_tests/test_dagster_daemon.py

View Options

python_modules/dagster/dagster_tests/daemon_tests/test_dagster_daemon_health.py

View Options

python_modules/libraries/dagster-postgres/dagster_postgres/run_storage/run_storage.py

[RFC] Errors in daemon heartbeats42aa8f151a4dActions

Description

Details

Event Timeline

Changes (9)

R1:42aa8f151a4d

python_modules/dagster/dagster/core/storage/runs/schema.py

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

python_modules/dagster/dagster/daemon/controller.py

python_modules/dagster/dagster/daemon/daemon.py

python_modules/dagster/dagster/daemon/types.py

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py

python_modules/dagster/dagster_tests/daemon_tests/test_dagster_daemon.py

python_modules/dagster/dagster_tests/daemon_tests/test_dagster_daemon_health.py

python_modules/libraries/dagster-postgres/dagster_postgres/run_storage/run_storage.py

[RFC] Errors in daemon heartbeats
42aa8f151a4d
Actions