HomePhabricator

Add compute logging watcher process to kill tail (and itself) if parent dies

Authored by prha on Wed, Oct 2, 4:42 AM.

Description

Add compute logging watcher process to kill tail (and itself) if parent dies

Summary: Kind of crappy that we're spawning two processes (one to tail, one to watch), but I like this better than having the ComputeLogManager do the bookkeeping on all of the spawned tail processes and killing off orphaned ones.

Test Plan:
bk, also ran the dagster-graphql multiprocessing test and saw that the crashed solid did
not orphan a tail process

Reviewers: #ft, schrockn

Reviewed By: #ft, schrockn

Subscribers: schrockn

Differential Revision: https://dagster.phacility.com/D1154

Details

Committed
prhaWed, Oct 2, 4:30 PM
Reviewer
Restricted Project
Differential Revision
D1154: Add compute logging watcher process to kill tail (and itself) if parent dies
Parents
R1:a9ea560d372a: (add-cancellation-9) Add graphql interface for cancellation
Branches
Unknown
Tags
Unknown