HomeElementl

local_file_manager defaults to <instance storage dir>/file_manager (#4462)

Description

local_file_manager defaults to <instance storage dir>/file_manager (#4462)

https://github.com/dagster-io/dagster/issues/3898

status-quo:

  • to custom the path for output notebook, users need to configure the base_dir directly on the file manager they use
  • local_file_manager defaults to the current dir, i.e. path .

this PR defaults the base_dir of local_file_manager to <instance's local_artifact_storage>/storage/file_manager

here we decide to add a folder file_manager to avoid having all the run_id dirs and all the temp file names written by file managers at the same level.

Note that file manager may not be a long term plan for file handling during execution. This PR is more for resolving the confusion as its pattern differs from the rest of the system.

Details

Provenance
yuhanAuthored on Aug 6 2021, 7:47 PM
GitHub <noreply@github.com>Committed on Aug 6 2021, 7:47 PM
Parents
R1:46f25a984c59: Automation: versioned docs for 0.12.5
Branches
Unknown
Tags
Unknown