Clean up gRPC servers when there's an error in the constructor (for example…
2b80a3bae90dUnpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Clean up gRPC servers when there's an error in the constructor (for example, not being able to load the code on the server)

Summary: This was causing memory leaks in tests and is generally a bad thing that we shouldn't do.

Test Plan: BK, in particular run test_bad_schedules_mixed_with_good_schedule 25 times, no longer OOMs

Reviewers: alangenfeld, prha, sashank

Differential Revision: https://dagster.phacility.com/D5118

Details

Provenance

dgibson

Authored on Nov 12 2020, 2:27 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.