HomeElementl

[dagit] Don't show shortcut hints on screen capture command

Description

[dagit] Don't show shortcut hints on screen capture command

Summary:
Resolves #3012

Modify the shortcut keydown listener so that we stop showing shortcut hints when using commands like Cmd+Shift+4 to take screen captures.

The behavior will be:

  • Any modifier pressed for more than 800ms will display the hints
  • If any other key is pressed, including other modifiers, the timeout will be cleared and the hints will not be displayed

Test Plan:
Verify that I can use Cmd+Shift+4 to take a screen capture, with no shortcut hints showing up.

Also verify that shorcuts still behave properly, and that holding down a modifier key will show the hints after 800ms.

Reviewers: bengotow, sashank, sandyryza

Reviewed By: sashank

Differential Revision: https://dagster.phacility.com/D5401

Details

Provenance
dishAuthored on Dec 2 2020, 11:20 PM
Reviewer
sashank
Differential Revision
D5401: [dagit] Don't show shortcut hints on screen capture command
Parents
R1:9593533130c5: [dagit] Properly disable LaunchButton
Branches
Unknown
Tags
Unknown