Paths

Table of Contentst

Diffusion dagster 1925f1043faf

[dagit] Add `id` to PartitionSet
1925f1043faf
Actions

Description

[dagit] Add id to PartitionSet

Summary: While looking into #3503 I noticed an Apollo warning about PartitionSet needing an id field for better caching. This adds it, just duplicating the name field.

Test Plan: View partition set in Dagit, click to view different "Last X" slices, verify that the Apollo warning is gone.

Reviewers: bengotow, sandyryza, dgibson

Reviewed By: bengotow, dgibson

Differential Revision: https://dagster.phacility.com/D5839

Details

Provenance

• dish

Authored on Jan 6 2021, 4:48 PM

Reviewer

• bengotow

Differential Revision

D5839: [dagit] Add `id` to PartitionSet

Parents

R1:f1bcad9be660: Consolidate helm image name template function

Branches

Unknown

Tags

Unknown

Event Timeline

• dish committed R1:1925f1043faf: [dagit] Add `id` to PartitionSet (authored by • dish).Jan 8 2021, 11:32 PM

• dish added an edge: D5839: [dagit] Add `id` to PartitionSet.

Changes (27)

Path

Size

.buildkite/

dagster-buildkite/

dagster_buildkite/

utils.py

js_modules/

dagit/

src/

execute/

ConfigEditorConfigPicker.tsx

types/

ConfigEditorGeneratorPartitionSetsFragment.ts

ConfigPartitionSelectionQuery.ts

ConfigPartitionsQuery.ts

ExecutionSessionContainerPartitionSetsFragment.ts

PipelineExecutionRootQuery.ts

instance/

types/

InstanceHealthQuery.ts

partitions/

PartitionsBackfill.tsx

PipelinePartitionsRoot.tsx

types/

PartitionSetNamesQuery.ts

PartitionsBackfillSelectorQuery.ts

PipelinePartitionsRootQuery.ts

useChunkedPartitionsQuery.tsx

schedules/

ScheduleUtils.tsx

types/

RepositorySchedulesFragment.ts

ScheduleFragment.ts

ScheduleRootQuery.ts

SchedulesRootQuery.ts

schema.graphql

workspace/

WorkspaceContext.tsx

types/

RootRepositoriesQuery.ts

python_modules/

dagster-graphql/

dagster_graphql/

schema/

partition_sets.py

dagster_graphql_tests/

graphql/

test_partition_sets.py

dagster/

core/

host_representation/

external.py

handle.py

origin.py

R1:1925f1043faf

View Options

.buildkite/dagster-buildkite/dagster_buildkite/utils.py

View Options

js_modules/dagit/src/execute/ConfigEditorConfigPicker.tsx

View Options

js_modules/dagit/src/execute/types/ConfigEditorGeneratorPartitionSetsFragment.ts

View Options

js_modules/dagit/src/execute/types/ConfigPartitionSelectionQuery.ts

View Options

js_modules/dagit/src/execute/types/ConfigPartitionsQuery.ts

View Options

js_modules/dagit/src/execute/types/ExecutionSessionContainerPartitionSetsFragment.ts

View Options

js_modules/dagit/src/execute/types/PipelineExecutionRootQuery.ts

View Options

js_modules/dagit/src/instance/types/InstanceHealthQuery.ts

View Options

js_modules/dagit/src/partitions/PartitionsBackfill.tsx

View Options

js_modules/dagit/src/partitions/PipelinePartitionsRoot.tsx

View Options

js_modules/dagit/src/partitions/types/PartitionSetNamesQuery.ts

View Options

js_modules/dagit/src/partitions/types/PartitionsBackfillSelectorQuery.ts

View Options

js_modules/dagit/src/partitions/types/PipelinePartitionsRootQuery.ts

View Options

js_modules/dagit/src/partitions/useChunkedPartitionsQuery.tsx

View Options

js_modules/dagit/src/schedules/ScheduleUtils.tsx

View Options

js_modules/dagit/src/schedules/types/RepositorySchedulesFragment.ts

View Options

js_modules/dagit/src/schedules/types/ScheduleFragment.ts

View Options

js_modules/dagit/src/schedules/types/ScheduleRootQuery.ts

View Options

js_modules/dagit/src/schedules/types/SchedulesRootQuery.ts

View Options

js_modules/dagit/src/schema.graphql

View Options

js_modules/dagit/src/workspace/WorkspaceContext.tsx

View Options

js_modules/dagit/src/workspace/types/RootRepositoriesQuery.ts

View Options

python_modules/dagster-graphql/dagster_graphql/schema/partition_sets.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_partition_sets.py

View Options

python_modules/dagster/dagster/core/host_representation/external.py

View Options

python_modules/dagster/dagster/core/host_representation/handle.py

View Options

python_modules/dagster/dagster/core/host_representation/origin.py

[dagit] Add `id` to PartitionSet1925f1043fafActions

Description

Details

Event Timeline

Changes (27)

R1:1925f1043faf

.buildkite/dagster-buildkite/dagster_buildkite/utils.py

js_modules/dagit/src/execute/ConfigEditorConfigPicker.tsx

js_modules/dagit/src/execute/types/ConfigEditorGeneratorPartitionSetsFragment.ts

js_modules/dagit/src/execute/types/ConfigPartitionSelectionQuery.ts

js_modules/dagit/src/execute/types/ConfigPartitionsQuery.ts

js_modules/dagit/src/execute/types/ExecutionSessionContainerPartitionSetsFragment.ts

js_modules/dagit/src/execute/types/PipelineExecutionRootQuery.ts

js_modules/dagit/src/instance/types/InstanceHealthQuery.ts

js_modules/dagit/src/partitions/PartitionsBackfill.tsx

js_modules/dagit/src/partitions/PipelinePartitionsRoot.tsx

js_modules/dagit/src/partitions/types/PartitionSetNamesQuery.ts

js_modules/dagit/src/partitions/types/PartitionsBackfillSelectorQuery.ts

js_modules/dagit/src/partitions/types/PipelinePartitionsRootQuery.ts

js_modules/dagit/src/partitions/useChunkedPartitionsQuery.tsx

js_modules/dagit/src/schedules/ScheduleUtils.tsx

js_modules/dagit/src/schedules/types/RepositorySchedulesFragment.ts

js_modules/dagit/src/schedules/types/ScheduleFragment.ts

js_modules/dagit/src/schedules/types/ScheduleRootQuery.ts

js_modules/dagit/src/schedules/types/SchedulesRootQuery.ts

js_modules/dagit/src/schema.graphql

js_modules/dagit/src/workspace/WorkspaceContext.tsx

js_modules/dagit/src/workspace/types/RootRepositoriesQuery.ts

python_modules/dagster-graphql/dagster_graphql/schema/partition_sets.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_partition_sets.py

python_modules/dagster/dagster/core/host_representation/external.py

python_modules/dagster/dagster/core/host_representation/handle.py

python_modules/dagster/dagster/core/host_representation/origin.py

[dagit] Add `id` to PartitionSet
1925f1043faf
Actions