HomeElementl

[dagit] Use lint to enforce query inclusion of `id` field

Description

[dagit] Use lint to enforce query inclusion of id field

Summary:
In an effort to improve our Apollo caching, use id fields more consistently in GraphQL.

  • Add a few new id fields where we currently have a value that can be used, plus a couple others that seemed reasonable (please push back if I'm wrong)
  • Use the GraphQL eslint plugin to enforce that id is used whenever it is available on a type
  • Repair all lint errors by adding id as needed
  • Remove a handful manual ids from AppCache

Ideally we would be able to use this anywhere that Apollo currently shows a cache warning.

Test Plan: Lint, jest, ts. Load Dagit, navigate around and verify that things look fine.

Reviewers: dgibson, alangenfeld, sashank, prha, bengotow

Reviewed By: prha

Differential Revision: https://dagster.phacility.com/D5137

Details

Provenance
dishAuthored on Nov 12 2020, 5:52 PM
Reviewer
prha
Differential Revision
D5137: [dagit] Use lint to enforce query inclusion of `id` field
Parents
R1:15de4f90b3d9: [easy] Fix deprecation warning and do not return value from hammer_pipeline
Branches
Unknown
Tags
Unknown