Page MenuHomePhabricator

[1/3] Display latest runs in schedule UI
ClosedPublic

Authored by sashank on Sep 10 2019, 7:06 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:ab69a16d0b1f: [1/3] Display latest runs in schedule UI
Summary

Display a list of runs and their statuses that were created by each schedule in the Schedule UI, as well as the date of the last run. You can click on the status dot to navigate to the log viewer for the run. The list refreshes every 15 seconds, just like the runs history page.

Depends on: D980

Test Plan
cd projects/dagster/examples/dagster_examples/experimental
dagit -p 3333

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Sep 10 2019, 7:06 PM
sashank planned changes to this revision.Sep 10 2019, 8:03 PM
sashank planned changes to this revision.Sep 19 2019, 5:33 PM
sashank edited the summary of this revision. (Show Details)
sashank edited the summary of this revision. (Show Details)Sep 20 2019, 12:31 AM
sashank edited the summary of this revision. (Show Details)
sashank edited the test plan for this revision. (Show Details)
sashank edited the summary of this revision. (Show Details)Sep 20 2019, 12:34 AM
sashank updated this revision to Diff 4891.Sep 20 2019, 12:36 AM
sashank edited the test plan for this revision. (Show Details)

Clean up + add date for most recent run

sashank updated this revision to Diff 4893.Sep 20 2019, 1:07 AM

formatting

alangenfeld requested changes to this revision.Sep 20 2019, 3:59 PM
alangenfeld added a subscriber: alangenfeld.

lets get some basic integration test coverage for doing a run with a tag and querying it back out

js_modules/dagit/src/runs/RunUtils.tsx
17–22

unixToString

should probably be date/time somewhere in this name

This revision now requires changes to proceed.Sep 20 2019, 3:59 PM
sashank retitled this revision from Display latest runs in schedule UI to [1/3] Display latest runs in schedule UI.Sep 20 2019, 4:45 PM
alangenfeld requested changes to this revision.Sep 20 2019, 6:12 PM

We already have that integration test here

thats close but not quite what i was talking about - that tests doesn't fetch back out of storage

python_modules/dagster-graphql/dagster_graphql/schema/run_schedule.py
81–87

this is the code im asking to be put under test

python_modules/dagster/dagster/core/storage/runs.py
130–218

slash this code if you want to test at a lower level

This revision now requires changes to proceed.Sep 20 2019, 6:12 PM
sashank updated this revision to Diff 4926.Sep 20 2019, 9:45 PM

Add test for all_runs_for_tag

Got it - sorry! Updated the same test to check the run storage as well

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execute_pipeline.py
612–615

Added the test here

alangenfeld accepted this revision.Sep 20 2019, 9:47 PM
alangenfeld added inline comments.
python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execute_pipeline.py
612–615

redfordnod

This revision is now accepted and ready to land.Sep 20 2019, 9:47 PM
sashank updated this revision to Diff 4927.Sep 20 2019, 9:48 PM

formatting

sashank updated this revision to Diff 4932.Sep 20 2019, 10:57 PM

make graphql