Page MenuHomePhabricator

dagster-airflow CLI fixes
ClosedPublic

Authored by natekupp on Tue, Sep 10, 4:10 AM.

Details

Test Plan

docs and manual CLI test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp updated this revision to Diff 4511.Tue, Sep 10, 4:10 AM
natekupp created this revision.

up

Harbormaster completed remote builds in B3614: Diff 4511.
alangenfeld accepted this revision.Tue, Sep 10, 5:44 PM
alangenfeld added inline comments.
docs/sections/deploying/airflow.md
26–27

should we talk about presets / the other CLI options here in the docs somewhere?

python_modules/dagster-airflow/dagster_airflow/cli.py
74–78

should we make this more aggressive? some big comment block shit?

155–156

oh cool we already support presets

This revision is now accepted and ready to land.Tue, Sep 10, 5:44 PM
natekupp updated this revision to Diff 4540.Tue, Sep 10, 7:03 PM
natekupp marked 2 inline comments as done.

up

natekupp marked an inline comment as done.Tue, Sep 10, 7:06 PM
natekupp added inline comments.
docs/sections/deploying/airflow.md
26–27

definitely - added a section w/ presets

python_modules/dagster-airflow/dagster_airflow/cli.py
74–78

yeah good idea, done

natekupp updated this revision to Diff 4542.Tue, Sep 10, 7:12 PM
natekupp marked an inline comment as done.

rebase

This revision was automatically updated to reflect the committed changes.