Page MenuHomePhabricator

Basic implementation of search through run history
ClosedPublic

Authored by bengotow on Mon, Sep 9, 10:32 PM.

Details

Reviewers
schrockn
prha
Group Reviewers
Restricted Project
Commits
R1:c827de8558d8: Basic implementation of search through run history
Summary

This diff adds a basic search bar to the runs list that searches pipeline name, mode,
and stepsToExecute (if present.) I'm planning to add autocompletion / tokenization in
a stacked diff.

This also includes a small GraphQL interface change - the type of stepKeysToExecute
was (string | null)[] | null which isn't quite right. If it's present, the elements
are non-null strings. Updated the dauphin representation and checked that it's now
(string | null)[]

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bengotow created this revision.Mon, Sep 9, 10:32 PM
schrockn requested changes to this revision.Mon, Sep 9, 11:23 PM
schrockn added a subscriber: schrockn.

can we also search for run id?

This revision now requires changes to proceed.Mon, Sep 9, 11:23 PM

Sure! Don't see why not. While I'm at it I'll make it so this search field can be populated from the query string - If there's some other place people are copy-pasting runIds from, it'd be cool to switch to a dagit link.

bengotow updated this revision to Diff 4703.Fri, Sep 13, 2:58 PM

Make runId searchable, support /runs?q=<term> so nobody is copy-pasting runIds

bengotow updated this revision to Diff 4707.Fri, Sep 13, 4:04 PM

Rebasing

prha accepted this revision.Fri, Sep 13, 10:36 PM
prha added a subscriber: prha.

lgtm

schrockn accepted this revision.Mon, Sep 16, 3:48 PM
This revision is now accepted and ready to land.Mon, Sep 16, 3:48 PM