Page MenuHomePhabricator

Update S3 scratch bucket to fix tests
ClosedPublic

Authored by natekupp on Mon, Sep 9, 2:04 AM.

Details

Summary

Using a new scratch bucket on S3.

I had previously been using "dagster-scratch". I attempted to mutate the AWS provider of that bucket in Pulumi today, and Pulumi tried to delete and recreate it—but it can't do that, since the bucket has the same name, and recreating a bucket right after deletion is not supported (takes somewhere between 15 mins to multiple hours before it is available again).

This uses a Pulumi-suffixed bucket, which ensures that issue won't happen again—but we'll still need to find a way to keep dagster and Pulumi synchronized if we ever change the bucket name again.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Mon, Sep 9, 2:04 AM
natekupp retitled this revision from Fix S3 scratch bucket to Update S3 scratch bucket.Mon, Sep 9, 2:17 AM
natekupp edited the summary of this revision. (Show Details)
natekupp added a reviewer: schrockn.
natekupp retitled this revision from Update S3 scratch bucket to Update S3 scratch bucket to fix tests.Mon, Sep 9, 2:21 AM
natekupp edited the summary of this revision. (Show Details)
schrockn accepted this revision.Mon, Sep 9, 2:21 AM
This revision is now accepted and ready to land.Mon, Sep 9, 2:21 AM