Page MenuHomePhabricator

(postgres-infra-1) Postgres Module and Test Infrastructure
ClosedPublic

Authored by schrockn on Sun, Sep 8, 3:45 PM.

Details

Summary

Setup a dagster-postgres module with a test

Test Plan

Run test locally

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Sun, Sep 8, 3:45 PM
Harbormaster failed remote builds in B3519: Diff 4396!
schrockn updated this revision to Diff 4400.Sun, Sep 8, 4:22 PM
schrockn added reviewers: Restricted Project, max, alangenfeld.

up

Harbormaster completed remote builds in B3521: Diff 4398.
Harbormaster failed remote builds in B3528: Diff 4405!
schrockn updated this revision to Diff 4407.Sun, Sep 8, 5:11 PM

load test

schrockn updated this revision to Diff 4408.Sun, Sep 8, 5:11 PM

load test

schrockn updated this revision to Diff 4409.Sun, Sep 8, 5:11 PM

load test

Harbormaster completed remote builds in B3531: Diff 4408.
schrockn updated this revision to Diff 4410.Sun, Sep 8, 6:03 PM

move file

schrockn updated this revision to Diff 4414.Sun, Sep 8, 11:06 PM
schrockn retitled this revision from Postgres Module and Test Infrastructure to (postgres-infra-1) Postgres Module and Test Infrastructure.

rename as stack

alangenfeld resigned from this revision.Mon, Sep 9, 3:31 PM

seems legit but ill let @max take a pass

natekupp accepted this revision.Mon, Sep 9, 6:14 PM
natekupp added a subscriber: natekupp.

See one comment

.buildkite/pipeline.py
148

can we keep the list of PG stuff in one spot and consume it both here and in the airline demo tests? worried these will end up getting out of sync

This revision is now accepted and ready to land.Mon, Sep 9, 6:14 PM
schrockn added inline comments.Mon, Sep 9, 6:21 PM
.buildkite/pipeline.py
148

i added some shared infra here: https://dagster.phacility.com/D977

do you mean in buildkite specifically or in general?

natekupp added inline comments.Mon, Sep 9, 6:31 PM
.buildkite/pipeline.py
148

ah I just mean the dance of up

"docker-compose stop",
"docker-compose rm -f",
"docker-compose up -d --remove-orphans",
"export POSTGRES_TEST_DB_HOST=`docker inspect --format '{{ .NetworkSettings.IPAddress }}' test-postgres-db`",

and down

"docker-compose stop",
"docker-compose rm -f",

seems like it should be put in one place; I saw you added remove-orphans above and worried about us doing similar things in the future and forgetting to update the other instances

max accepted this revision.Mon, Sep 9, 7:06 PM