Page MenuHomePhabricator

load instance features flags from base directory
ClosedPublic

Authored by prha on Fri, Sep 6, 11:18 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:6ff9102861ee: load instance features flags from base directory
Summary

Feature flags were not being accessed correctly in execution steps because
child processes were using an ephemeral DagsterInstance, which does not load
any feature flags.

We now pass in the root_directory through the multiprocessing context queue -
we should load the config from the root directory if it is available

Test Plan

same feature flags enabled in both parent and child process instances

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Fri, Sep 6, 11:18 PM
prha retitled this revision from load features from home directory to load instance features flags from base directory.Fri, Sep 6, 11:20 PM
prha edited the summary of this revision. (Show Details)
alangenfeld accepted this revision.Fri, Sep 6, 11:33 PM

hm this feels a little off - will have to think about better long term solution

This revision is now accepted and ready to land.Fri, Sep 6, 11:33 PM
prha added a comment.Fri, Sep 6, 11:49 PM

yeah, I have a bigger question which is what parts need to be passed over the queue and which don't and why...

but this unblocks me for now.

This revision was automatically updated to reflect the committed changes.