Page MenuHomePhabricator

Build Dagster Docker images nightly
ClosedPublic

Authored by natekupp on Fri, Sep 6, 10:26 PM.

Details

Reviewers
alangenfeld
max
Group Reviewers
Restricted Project
Commits
R1:6b7cc42f6599: Build Dagster Docker images nightly
Summary

This builds and pushes Docker images to dagster/dagster-py37:latest / dagster/dagster-py37:2019-01-01, for all 4 Pythons, nightly.

Images are built with a pull from master and make dev_install. Will create separate process in the future for tagging stable builds.

Test Plan

Tested build on main pipeline and it worked; tested build + push locally

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Fri, Sep 6, 10:26 PM
natekupp edited the summary of this revision. (Show Details)Mon, Sep 9, 4:16 AM
natekupp edited the test plan for this revision. (Show Details)
natekupp added a reviewer: Restricted Project.
natekupp retitled this revision from Build Docker image to Build Dagster Docker images on pushes to master.
natekupp updated this revision to Diff 4438.Mon, Sep 9, 4:25 AM
natekupp edited the summary of this revision. (Show Details)

up

whats the value in new images every diff?

.buildkite/step_builder.py
93–97

should at least check string is in known good set if were not going to use an enum or explicit methods

alangenfeld requested changes to this revision.Mon, Sep 9, 3:23 PM

nightly as discussed in person

This revision now requires changes to proceed.Mon, Sep 9, 3:23 PM
natekupp retitled this revision from Build Dagster Docker images on pushes to master to Build Dagster Docker images nightly.Mon, Sep 9, 5:08 PM
natekupp edited the summary of this revision. (Show Details)
max accepted this revision.Mon, Sep 9, 10:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 9, 10:38 PM
This revision was automatically updated to reflect the committed changes.