Page MenuHomePhabricator

mirror instead of redirect output to file [unix only]
ClosedPublic

Authored by prha on Thu, Sep 5, 11:51 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:1a4f2e2cc144: mirror instead of redirect output to file [unix only]
Summary

tails the log file in a separate process

Test Plan

ran log spew in dagit, graphql, saw both stdout and file being written

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Thu, Sep 5, 11:51 PM
prha added a reviewer: Restricted Project.Thu, Sep 5, 11:54 PM
schrockn accepted this revision.Fri, Sep 6, 12:03 AM
schrockn added a subscriber: schrockn.

awesome

python_modules/dagster/dagster/core/execution/logs.py
204–210

this seems very much comment-worthy. no idea what is happening

python_modules/dagster/dagster/utils/__init__.py
20

eek is this isort?

This revision is now accepted and ready to land.Fri, Sep 6, 12:03 AM
prha updated this revision to Diff 4306.Fri, Sep 6, 1:32 AM

add comment, fix imports

prha updated this revision to Diff 4328.Fri, Sep 6, 6:22 PM

rebase

This revision was landed with ongoing or failed builds.Fri, Sep 6, 6:35 PM
This revision was automatically updated to reflect the committed changes.