Page MenuHomePhabricator

Eliminate make isort
ClosedPublic

Authored by schrockn on Thu, Sep 5, 2:49 AM.

Details

Reviewers
natekupp
Group Reviewers
Restricted Project
Commits
R1:8fa944808d8b: Eliminate make isort
Summary

I just borked my machine by running make isort.

It is described in this issue: https://github.com/timothycrosley/isort/issues/759

Until we figure out a workaround let's remove it for now to not encourage this
treachery.

Test Plan

Buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Thu, Sep 5, 2:49 AM
natekupp added inline comments.
.buildkite/pipeline.py
364

won't this do the same thing?

schrockn added inline comments.Thu, Sep 5, 3:25 AM
.buildkite/pipeline.py
364

Yes does the same thing but only during the build which is fine. I'm just trying to prevent this someone from doing this to their local machine through the make command.

natekupp accepted this revision.Thu, Sep 5, 3:25 AM

got it, sg!

This revision is now accepted and ready to land.Thu, Sep 5, 3:25 AM
This revision was automatically updated to reflect the committed changes.
alangenfeld added inline comments.
Makefile
84

doing

isort `git ls-files '*.py'`

should avoid the problem

schrockn added inline comments.Thu, Sep 5, 4:47 PM
Makefile
84

good idea. i was just traumatized.