Page MenuHomePhabricator

[Docs] Add docs for standalone hosted Dagit
ClosedPublic

Authored by natekupp on Wed, Sep 4, 10:05 PM.

Details

Reviewers
schrockn
Group Reviewers
Restricted Project
Commits
R1:674eb52ad61f: [Docs] Add docs for standalone hosted Dagit
Test Plan

docs only, manually tested Dockerfile example

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Wed, Sep 4, 10:05 PM
schrockn accepted this revision.Thu, Sep 5, 1:44 AM
schrockn added a subscriber: schrockn.

awesome

docs/sections/deploying/dagit.md
22

my one concern (in general) is the risk of devs smashing each other's code here. it would be good to think about and have a solution for that.

33

I would still explicitly recommend using virtual environments on a bare vm

This revision is now accepted and ready to land.Thu, Sep 5, 1:44 AM
natekupp added inline comments.Thu, Sep 5, 3:24 AM
docs/sections/deploying/dagit.md
22

Yeah this is a good callout. By default, everyone gets their own VM / EC2 instance, in which case this wouldn't happen.

The situation where this would happen is if devs explicitly created a single VM and shared the configs / SSH keys so that multiple devs were pushing to the same box, and they pushed at the same time.

We can implement a naive locking scheme to ensure that a second "up" can't be launched while another one is in flight. I'll file an issue for this

33

agree - will add that