Page MenuHomeElementl

update type annotations on context properties
ClosedPublic

Authored by sandyryza on Aug 12 2021, 11:26 PM.

Details

Summary
  • Resources -> Any
  • raise errors instead of marking properties Optional
Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
output-context-optional (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

sandyryza retitled this revision from mypy-able to update type annotations on context properties.Aug 12 2021, 11:33 PM
sandyryza edited the summary of this revision. (Show Details)
sandyryza added reviewers: cdecarolis, alangenfeld.
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 12 2021, 11:49 PM
Harbormaster failed remote builds in B34646: Diff 42862!
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 13 2021, 12:44 AM
Harbormaster failed remote builds in B34648: Diff 42864!
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 13 2021, 3:10 PM
Harbormaster failed remote builds in B34652: Diff 42869!

@cdecarolis - ping on this in case it got lost with the Github transition.

alangenfeld added inline comments.
python_modules/dagster/dagster/core/errors.py
551–555

nit: i feel like you could get by with the general invariant violation error, the message is pretty clear

This revision is now accepted and ready to land.Aug 24 2021, 4:42 PM
This revision was landed with ongoing or failed builds.Aug 24 2021, 5:30 PM
This revision was automatically updated to reflect the committed changes.