Page MenuHomeElementl
Differential D9221

update type annotations on context properties
ClosedPublic
Actions

Authored by sandyryza on Aug 12 2021, 11:26 PM.

Details

Reviewers
cdecarolis
alangenfeld
Commits
R1:211b178db535: update type annotations on context properties
Summary
  • Resources -> Any
  • raise errors instead of marking properties Optional
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sandyryza created this revision.Aug 12 2021, 11:26 PM
sandyryza retitled this revision from mypy-able to update type annotations on context properties.Aug 12 2021, 11:33 PM
sandyryza edited the summary of this revision. (Show Details)
sandyryza added reviewers: cdecarolis, alangenfeld.
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 12 2021, 11:49 PM
Harbormaster failed remote builds in B34646: Diff 42862!
sandyryza updated this revision to Diff 42864.Aug 13 2021, 12:13 AM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 13 2021, 12:44 AM
Harbormaster failed remote builds in B34648: Diff 42864!
sandyryza updated this revision to Diff 42869.Aug 13 2021, 2:49 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 13 2021, 3:10 PM
Harbormaster failed remote builds in B34652: Diff 42869!
sandyryza updated this revision to Diff 42876.Aug 13 2021, 6:27 PM

up

Harbormaster completed remote builds in B34658: Diff 42876.Aug 13 2021, 6:50 PM
sandyryza requested review of this revision.Aug 13 2021, 6:50 PM
sandyryza added a comment.Aug 23 2021, 8:08 PM

@cdecarolis - ping on this in case it got lost with the Github transition.

alangenfeld accepted this revision.Aug 24 2021, 4:42 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/errors.py
551–555 ↗(On Diff #42876)

nit: i feel like you could get by with the general invariant violation error, the message is pretty clear

This revision is now accepted and ready to land.Aug 24 2021, 4:42 PM
sandyryza updated this revision to Diff 42914.Aug 24 2021, 4:54 PM

up

Harbormaster failed remote builds in B34684: Diff 42914!Aug 24 2021, 5:18 PM
This revision was landed with ongoing or failed builds.Aug 24 2021, 5:30 PM
Closed by commit R1:211b178db535: update type annotations on context properties (authored by sandyryza). · Explain Why
This revision was automatically updated to reflect the committed changes.
sandyryza added a commit: R1:211b178db535: update type annotations on context properties.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
execution/
context/
3 lines
66 lines
101 lines
storage/
4 lines

Diff 42915

View Options

python_modules/dagster/dagster/core/execution/context/compute.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/context/input.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/context/output.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/intermediate_storage.py

Loading...